Log console output during replay to file

[abitmore]

User Story
As a node admin I want console output during replay be saved to log files according to logging configurations in config.ini or logging.ini, so that later diagnosis would be easier.

CORE TEAM TASK LIST

• Evaluate / Prioritize Feature Request
• Refine User Stories / Requirements
• Define Test Cases
• Design / Develop Solution
  • Assigned: @cogutvalera
  • Estimated: 2 hours
  • Remitted: Week 39
• Perform QA/Testing
• Update Documentation

[cogutvalera]

@ryanRfox I want to claim this issue.

Thanks !

[ryanRfox]

I've assigned @cogutvalera for this issue. Please provide an estimate prior to developing the solution. We want @bitshares/core-dev to review.

[cogutvalera]

@ryanRfox my estimation for this issue is approximately 2 hours

[cogutvalera]

@abitmore

1. Maybe I've missed something but let me ask: do you mean logging.ini instead of config.ini ? right ?
2. Can you paste here please (when you will have enough time for this) a example snippet copied from console log during replay that we need to log into file ?

Trying to understand more clearly the issue.

Thanks !

[abitmore]

No matter config.ini or logging.ini (when this issue is created there was no logging.ini).

[cogutvalera]

Thank you ! Just wanted to clarify some details for myself so I get the idea correctly enough.

[cogutvalera]

PR is ready just for bitshares-fc repo bitshares/bitshares-fc#76

[pmconrad]

IMO the FC change is not sufficient to fix this ticket. There's a lot of stuff "logged" via cout/cerr (for some of it that's ok though).

[cogutvalera]

Do not we have to create another new issue to avoid all stuff "logged" via cout/cerr ? So that we will have all stuff logged in the same manner according logging configuration. Or we don't need it ?

[pmconrad]

I always understood this ticket to be about cout/cerr. Didn't even know there was a problem with file_appender. :-)

[abitmore]

I don't have an opinion about cout/cerr, perhaps some of them are intended, perhaps not. Yes we can create an issue to check all of them.

[pmconrad]

I would like to see the replay percentage in the logs.

[cogutvalera]

would like to see the replay percentage in the logs.

For this we need to change in database::reindex log instruction with std::cerr to call ilog

[cogutvalera]

it must be done in #1289 issue, I will commit it there

[cogutvalera]

I would like to see the replay percentage in the logs.

is done in PR #1335 by next commit 83a66c8

[pmconrad]

Merged bitshares/bitshares-fc#76, please bump fc.
There are a few uses of std::cerr in application.cpp and in witness plugin that might be better placed in a logfile, please check.

[cogutvalera]

@pmconrad fc bumped

[cogutvalera]

we can close this issue because both PRs #1355 / bitshares/bitshares-fc#76 are merged already

[cogutvalera]

Thanks !

[pmconrad]

Yep. Thanks for the reminder.

[cogutvalera]

Thank you !