Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

Merged
merged 7 commits into from
Sep 3, 2018
Merged

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d370b3f
Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete
jmjatlanta Jun 13, 2018
e02ad1f
Fix merge conflict
jmjatlanta Aug 23, 2018
bab3348
enable subscribe_to_all by default
jmjatlanta Aug 24, 2018
7b02d9a
Make default cl param not take boolean
jmjatlanta Sep 1, 2018
1c3cc77
Remove test code
jmjatlanta Sep 1, 2018
5f34955
Fixed logic error on eval of param
jmjatlanta Sep 1, 2018
f7d3747
Add white space to keep you-know-who happy
jmjatlanta Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/app/application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ void application_impl::startup()
}

if( _options->count("enable-subscribe-to-all") )
_app_options.enable_subscribe_to_all = _options->at("enable-subscribe-to-all").as<bool>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get it, what's wrong with _options->at("enable-subscribe-to-all").as<bool>();?

Copy link
Contributor Author

@jmjatlanta jmjatlanta Sep 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't add the command line option, you get an index out of range error.

Update: Okay, I see what you mean. I'm fixing it.

_app_options.enable_subscribe_to_all = true;

if( _active_plugins.find( "market_history" ) != _active_plugins.end() )
_app_options.has_market_history_plugin = true;
Expand Down
2 changes: 1 addition & 1 deletion libraries/app/include/graphene/app/application.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace graphene { namespace app {
class application_options
{
public:
bool enable_subscribe_to_all = true;
bool enable_subscribe_to_all = false;
bool has_market_history_plugin = false;
};

Expand Down