Refactor cli_test #1192 #1243

cogutvalera · 2018-08-09T18:22:39Z

ryanRfox · 2018-08-09T20:13:52Z

This is ready for testing. Valera mentioned his original estimate of 4 hours was too few. Now estimating 10 hours. Core Team: please assist me with revising the estimation based on the original Issue, comments, development and resulting PR.

cogutvalera · 2018-08-09T20:22:31Z

I've spent even more than 10 hours, so guys specify your estimation please and I will agree with it, because I'm still new dev in BitShares Core and my estimation maybe wrong for you ;-) you know better than me how many hours it would take for you ...

oxarbitrage · 2018-08-10T14:30:07Z

tests/cli/main.cpp

-   using namespace graphene::chain;
-   using namespace graphene::app;
+   //using namespace graphene::chain;
+   //using namespace graphene::app;


pls remove comments.

sure ! removed ! thanks !

oxarbitrage

looks good to me, tested and works as expected. well done.

cogutvalera · 2018-08-10T14:36:39Z

Thanks !

cogutvalera · 2018-08-14T11:04:55Z

can we merge this PR and close related issue ? or this is not still ready and need some changes and improvements ? if YES, then which changes and improvements in your opinion ?

Thanks !

abitmore · 2018-08-14T12:32:15Z

I'd say split it into smaller files.

abitmore · 2018-08-14T12:35:31Z

tests/cli/main.cpp

-   }
-   app1->shutdown();
+    try
+    {


Why changed the indentation to 4 white spaces (both above and below)?

where can I see BitShares Core coding convention ? I prefer 4 white spaces, what do you prefer ?

3 spaces. sorry @abitmore i didnt saw this one.

indentation everywhere in BitShares Core code base is prefer to 3 spaces ?

yes. 3 spaces everywhere(except p2p code that uses 2 but we don't want to change that now)

ok sure. Thank you very much ! Does BitShares Core have code convention ?

Can you please change the indentation back to 3 white spaces? Thanks.

We don't have code conventions so far.

abitmore · 2018-08-14T12:41:05Z

tests/cli/main.cpp

+    account_object nathan_acct_after_upgrade;
+    graphene::wallet::brain_key_info bki;
+    signed_transaction create_acct_tx;
+    signed_transaction transfer_tx;


Should not define so many different transaction objects in cli_fixture; nathan_acct_before_upgrade and nathan_acct_after_upgrade should not be here as well; they should be declared in individual test cases.

abitmore · 2018-08-14T12:44:14Z

tests/cli/main.cpp

+
+            BOOST_TEST_MESSAGE("Importing nathan's balance");
+            import_txs = con->wallet_api_ptr->import_balance("nathan", nathan_keys, true);
+            nathan_acct_before_upgrade = con->wallet_api_ptr->get_account("nathan");


The nathan account upgrading should be in a "basic" test case and be invoked by needed test cases, but not in fixture.

abitmore · 2018-08-14T12:45:07Z

tests/cli/main.cpp

+            // create a new account
+            bki = con->wallet_api_ptr->suggest_brain_key();
+            BOOST_CHECK(!bki.brain_priv_key.empty());
+            create_acct_tx = con->wallet_api_ptr->create_account_with_brain_key(bki.brain_priv_key, "jmjatlanta", "nathan", "nathan", true);


The jmj account creation should be in a test case as well.

abitmore · 2018-08-14T12:45:30Z

tests/cli/main.cpp

+
+            // attempt to give jmjatlanta some bitsahres
+            BOOST_TEST_MESSAGE("Transferring bitshares from Nathan to jmjatlanta");
+            transfer_tx = con->wallet_api_ptr->transfer("nathan", "jmjatlanta", "10000", "1.3.0", "Here are some CORE token for your new account", true);


The transfer should not be in cli_fixture.

cogutvalera · 2018-08-18T12:42:05Z

made improvements as @abitmore mentioned, do we need here some more changes/improvements or not ?

abitmore · 2018-08-23T00:10:44Z

tests/cli/main.cpp

-   }
-   app1->shutdown();
+    try
+    {


Can you please change the indentation back to 3 white spaces? Thanks.

We don't have code conventions so far.

abitmore · 2018-08-23T00:16:04Z

tests/cli/main.cpp

+   int server_port_number {0};
+   fc::temp_directory app_dir = graphene::utilities::temp_directory_path();
+   std::shared_ptr<graphene::app::application> app1 = start_application(app_dir, server_port_number);
+   client_connection* con = new client_connection(app1, app_dir, server_port_number);


Initializing these variables here is a bad idea. They're heavy. Better move them to a constructor. Then some member variables can be changed to local variable.

By the way, why need to use a pointer?

fixed indentation from 4 white spaces to 3 (commit is ready)

initializing variables in constructor has different compile errors, need to fight all them, trying to understand why they happened, still fighting ...

I've used pointer because without pointer I had compile errors, still trying to understand why and still fighting with them ...

unknown location(0): fatal error: in "cli_connect": memory access violation at address: 0x00000064: no mapping at fault address /home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/tests/cli/main.cpp(260): last checkpoint: "cli_connect" fixture ctor *** 1 failure is detected in the test module "Test Application"

such error I see when trying to call next method:

app_dir = graphene::utilities::temp_directory_path();

It means next:

BOOST_FIXTURE_TEST_CASE( cli_connect, cli_fixture ) - this Boost fixture cannot call cli_fixture constructor with graphene::utilities::temp_directory_path() method inside, maybe I'm doing something wrong ? Still trying to understand the reason and to code as we desire !

fixed by direct initialization instead of using assignment operators inside constructor body

abitmore · 2018-08-23T00:21:05Z

tests/cli/main.cpp

+        // upgrade nathan
+        BOOST_TEST_MESSAGE("Upgrading Nathan to LTM");
+        upgrade_tx = con->wallet_api_ptr->upgrade_account("nathan", true);
+        nathan_acct_after_upgrade = con->wallet_api_ptr->get_account("nathan");


The upgrade of nathan account can be abstracted to a single test case, then be invoked by other test cases. See this for example:

bitshares-core/tests/tests/operation_tests.cpp

Line 983 in 610dbf5

INVOKE(create_account_test);

will do it soon

INVOKE doesn't work well enough with test fixtures, also need to fight here with errors

…emory access violation error

…nment operators inside the constructor body

cogutvalera · 2018-08-27T09:03:26Z

guys, when you will have enough time check please my new changes, I've committed all required changes that were asked by @abitmore , hope all was done correctly enough, I've compiled and tested and it seems work absolutely as intended.

Thanks a lot !

abitmore

Looks much better now. Thanks!

abitmore · 2018-08-27T16:47:17Z

tests/cli/main.cpp


      // create a new account
      graphene::wallet::brain_key_info bki = con.wallet_api_ptr->suggest_brain_key();
      BOOST_CHECK(!bki.brain_priv_key.empty());
-      signed_transaction create_acct_tx = con.wallet_api_ptr->create_account_with_brain_key(
-                                                bki.brain_priv_key, "jmjatlanta", "nathan", "nathan", true);
+      signed_transaction create_acct_tx = con.wallet_api_ptr->create_account_with_brain_key(bki.brain_priv_key, "jmjatlanta", "nathan", "nathan", true);


Apparently your screen is wider than mine. I like the wrapped format, at max around 130 characters a line.

ok sure ! I will format the whole file right now as required !

abitmore · 2018-08-27T16:47:59Z

tests/cli/main.cpp

+      nathan_acct_after_upgrade = con.wallet_api_ptr->get_account("nathan");
+
+      // verify that the upgrade was successful
+      BOOST_CHECK_PREDICATE( std::not_equal_to<uint32_t>(), (nathan_acct_before_upgrade.membership_expiration_date.sec_since_epoch())(nathan_acct_after_upgrade.membership_expiration_date.sec_since_epoch()) );


This line is too long to fit in my screen as well.

By the way there were some long lines that didn't change, so I'm unable to comment on them. Please help wrap them as well.

abitmore · 2018-08-27T16:53:18Z

tests/cli/main.cpp

+   std::vector<std::string> nathan_keys;
+
+   cli_fixture() : 
+   server_port_number(0),


I think we can use some indentations here.

abitmore

Looks good to me so far. Waiting for CI reports.

cogutvalera · 2018-08-27T18:35:41Z

Thank you !

abitmore · 2018-08-27T20:44:55Z

@oxarbitrage @jmjatlanta @pmconrad your opinions?

oxarbitrage · 2018-08-27T21:13:30Z

i think it is looking great but i will suggest the following if possible:

the "create a new account", "save the private key for this new account in the wallet file" and "attempt to give jmjatlanta some bitsahres" are pretty common actions. maybe create test createaccount and add the 3 things there. then we can invoke this new test after upgrade_nathan_account.

for the new test to make sense you can add some checks on it like if the account was created and if the transfer went ok.

cogutvalera · 2018-08-28T04:13:05Z

@oxarbitrage thank you very much ! Your idea is great and makes sense ! I think I need to code it too. Is anybody disagree ?

abitmore · 2018-08-28T13:01:06Z

tests/cli/main.cpp


      // attempt to give jmjatlanta some bitsahres
      BOOST_TEST_MESSAGE("Transferring bitshares from Nathan to jmjatlanta");
-      for(int i = 1; i <= 200; i++)
+      for(int i = 1; i <= 199; i++)


Why this change? Something was broken?

nothing was broken, I've changed this because we have +1 transaction inside INVOKE create_new_account, and I've decided to decrease here history by -1 transaction. Should I change another way ? I can change BOOST_CHECK history transfers to 202 as an example here

bitshares-core/tests/cli/main.cpp

Line 518 in 18a78a5

BOOST_CHECK_EQUAL(201, history.size() );

what are your thoughts ? Thanks !

I've changed this because we have +1 transaction inside INVOKE create_new_account, and I've decided to decrease here history by -1 transaction.

Makes sense. Thanks.

pmconrad · 2018-08-28T16:26:02Z

Looks good, but haven't checked in depth.

oxarbitrage

looks good to me too, should be easier to add more tests here with the new framework. thanks.

cogutvalera · 2018-08-28T18:11:15Z

Thank you guys !

cogutvalera · 2018-08-29T03:36:45Z

Thanks for merge !

Refactor cli_test bitshares#1192

2a385bb

ryanRfox added the 2e Ready for Testing Status indicating the solution is sufficiently developed to begin testing label Aug 9, 2018

oxarbitrage reviewed Aug 10, 2018

View reviewed changes

oxarbitrage previously approved these changes Aug 10, 2018

View reviewed changes

removed comments

2ae75e3

cogutvalera dismissed oxarbitrage’s stale review via 2ae75e3 August 10, 2018 14:36

oxarbitrage previously approved these changes Aug 10, 2018

View reviewed changes

abitmore reviewed Aug 14, 2018

View reviewed changes

abitmore requested changes Aug 14, 2018

View reviewed changes

abitmore added this to the 201810 - Non-Consensus-Changing Release milestone Aug 16, 2018

more improvements in cli_test

6ab400e

cogutvalera dismissed oxarbitrage’s stale review via 6ab400e August 18, 2018 12:39

abitmore requested changes Aug 23, 2018

View reviewed changes

cogutvalera added 4 commits August 24, 2018 14:26

fixed indentation from 4 white spaces to 3

06307e1

initializing variables inside constructor except app_dir because of m…

db7e0ba

…emory access violation error

using direct initialization, which is more efficient than using assig…

f7bd5a6

…nment operators inside the constructor body

removed comments

db446ac

cogutvalera added 2 commits August 27, 2018 10:25

use cli_connection object instead of pointer

19fc55c

using INVOKE for upgrade Nathan's account

a1f84a9

abitmore reviewed Aug 27, 2018

View reviewed changes

improved format

524791e

abitmore previously approved these changes Aug 27, 2018

View reviewed changes

invoke create new account

18a78a5

cogutvalera dismissed abitmore’s stale review via 18a78a5 August 28, 2018 05:44

abitmore reviewed Aug 28, 2018

View reviewed changes

oxarbitrage approved these changes Aug 28, 2018

View reviewed changes

abitmore merged commit 0ad21dc into bitshares:develop Aug 29, 2018

oxarbitrage mentioned this pull request Sep 28, 2018

Refactor cli_test #1192

Closed

8 tasks

TheTaconator mentioned this pull request Oct 15, 2018

Release Notes for BitShares Core 201810 #1381

Closed

Refactor cli_test #1192 #1243

Refactor cli_test #1192 #1243

Conversation

cogutvalera commented Aug 9, 2018

ryanRfox commented Aug 9, 2018

cogutvalera commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oxarbitrage left a comment

Choose a reason for hiding this comment

cogutvalera commented Aug 10, 2018

cogutvalera commented Aug 14, 2018

abitmore commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cogutvalera commented Aug 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cogutvalera Aug 24, 2018 • edited Loading

Choose a reason for hiding this comment

cogutvalera Aug 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cogutvalera commented Aug 27, 2018 • edited Loading

abitmore left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cogutvalera Aug 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abitmore left a comment

Choose a reason for hiding this comment

cogutvalera commented Aug 27, 2018

abitmore commented Aug 27, 2018 • edited Loading

oxarbitrage commented Aug 27, 2018

cogutvalera commented Aug 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmconrad commented Aug 28, 2018

oxarbitrage left a comment

Choose a reason for hiding this comment

cogutvalera commented Aug 28, 2018

cogutvalera commented Aug 29, 2018

cogutvalera Aug 24, 2018 •

edited

Loading

cogutvalera Aug 26, 2018 •

edited

Loading

cogutvalera commented Aug 27, 2018 •

edited

Loading

cogutvalera Aug 27, 2018 •

edited

Loading

abitmore commented Aug 27, 2018 •

edited

Loading

cogutvalera commented Aug 28, 2018 •

edited

Loading