Change call_order_update_operation to return order_id #1269 #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
reviewed
Sep 30, 2018
|
|
||
| if( new_debt == 0 ) | ||
| { | ||
| FC_ASSERT( new_collateral == 0, "Should claim all collateral when closing debt position" ); | ||
| d.remove( *call_obj ); | ||
| return void_result(); | ||
| return call_order_id; |
There was a problem hiding this comment.
Should we return the id of a deleted object?
There was a problem hiding this comment.
why not ? :) IMHO the id of a deleted object may be helpful for looking history of that object, even it is better than return nothing ...
There was a problem hiding this comment.
Agree, makes sense to return it.
pmconrad
reviewed
Oct 1, 2018
libraries/chain/market_evaluator.cpp
Outdated
| @@ -264,13 +267,12 @@ void_result call_order_update_evaluator::do_apply(const call_order_update_operat | |||
| _bitasset_data->current_feed.maintenance_collateral_ratio ); | |||
| call.target_collateral_ratio = o.extensions.value.target_collateral_ratio; | |||
| }); | |||
| call_order_id = call_obj->id; | |||
There was a problem hiding this comment.
This is superfluous, modify() will not change the id.
|
any other changes must be here or we can approve and merge this PR ? Thanks a lot ! |
9 tasks
|
Thanks for review ! Thank you very much for your time and efforts ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1269 "Change call_order_update_operation to return order_id"