Resolve 1371: sorting of public_keys is inefficient #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
added
the
2f Testing
…_transaction_signatures
pmconrad
force-pushed
the
1371_performance_opt_2
branch
from
3826ef3 to
bbb8730
Compare
|
Rebased and adapted new test case from #1384 |
abitmore
changed the title
|
I updated title of this PR to more descriptive since it helps when viewing PR list. |
abitmore
modified the milestones:
201812 - Feature Release,
201905 - Consensus-Upgrade Release
abitmore
changed the base branch from
performance_opt
to
tmp-merge-perf-opt-to-develop
abitmore
changed the base branch from
tmp-merge-perf-opt-to-develop
to
develop
abitmore
modified the milestones:
201905 - Consensus-Upgrade Release,
201812 - Feature Release
abitmore
reviewed
Oct 26, 2018
4 tasks
|
It turns out that the check for irrelevant signatures relies on key ordering as well. Will have to refactor. |
pmconrad
force-pushed
the
1371_performance_opt_2
branch
from
aeea794 to
a3558aa
Compare
|
Test results so far indicate that this change does not result in significant speedup for replay, resync or resync with force-validate.
(Resync was done at different times of day, fluctuations due to network conditions are to be expected.) |
17 tasks
|
Measurements have shown this to be a non-issue. Closing. |
This was referenced Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented full solution for #1371
Also cherry-picked some changes from #1360