Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sahkan's seed node address #1402

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

SahkanDesertHawk
Copy link
Contributor

Seed updates for sahkan

Seed updates for sahkan
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to latest develop branch (target release time 201812) or perhaps release branch (target release time 201810).

@SahkanDesertHawk
Copy link
Contributor Author

Both blockchains are on the latest 2.0.180823 mainnet release.

@oxarbitrage
Copy link
Member

oxarbitrage commented Oct 26, 2018

What @abitmore means is to rebase the pull request to the corresponding repository. I suggest that this should go to develop but release is also an option if you want to be at master sooner.

To do this rebase, click the edit button next to the title:
rebase

And github will give you the option to change the base from master to develop.

I also suggest to change the pull request title into "Update sahkan seed nodes" or similar.

PD: The reason of the rebase is that as a development rule, we don't send any change directly into master except for changes in README.md.

@abitmore abitmore changed the base branch from master to tmp-master October 26, 2018 19:04
@abitmore abitmore changed the title Update application.cpp Update Sahkan's seed node address Oct 26, 2018
@abitmore abitmore merged this pull request into bitshares:tmp-master Oct 26, 2018
@abitmore abitmore added this to the 201810 - Feature Release milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants