Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fc after re-improving compile time resource usage #1417

Merged
merged 4 commits into from
Nov 8, 2018
Merged

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Nov 5, 2018

Careful, there are cli-related changes in there as well.

@oxarbitrage
Copy link
Member

travis passing but: Ran for 49 min 38 sec

oxarbitrage
oxarbitrage previously approved these changes Nov 5, 2018
@pmconrad
Copy link
Contributor Author

pmconrad commented Nov 7, 2018

Yes, compile time is still longer than it was before the change.
Modified .travis.yml to skip tests when time is running out.

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this travis changes are a good idea as after the cache is done with the build we can run again with the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants