-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings #1503
Closed
Closed
Fix compiler warnings #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log informational message when plugin starts
Fixed linker error
Prevent exception when querying account history
Incorrect rebase goofed PR. Closing to create new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #1246
Newer compilers throw many more warnings. These commits minimize the warnings by:
Moving the destructor to the implementation file still causes a warning, but it is at compile of the .cpp, not each time the .hpp is included.
Adding the compiler options squelches warnings that are caused by (1) boost and (2) a non-trivial copy.
There are still warnings about destructors throwing. I believe we should be using
exit()
instead of throwing, if we truly want to end the program, but these are sometimes within libraries. So I am unsure of the side effects (i.e. who all are using them, even outside the project).