Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright for 2020 #1525

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Update copyright for 2020 #1525

merged 4 commits into from
Jan 30, 2020

Conversation

ryanRfox
Copy link
Contributor

@ryanRfox ryanRfox commented Jan 10, 2019

Update copyright to cover 2020. For issue #1524.

@ryanRfox ryanRfox mentioned this pull request Jan 10, 2019
1 task
@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 10, 2019
abitmore
abitmore previously approved these changes Jan 10, 2019
@@ -1,5 +1,5 @@
Copyright (c) 2015-2016 Cryptonomex Inc. <contact@cryptonomex.com>
Copyright (c) 2015-2017 contributors <CONTRIBUTORS.txt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We have 2 lines of Copyright ?
  • We have a reference to CONTRIBUTORS.txt witch is empty.

I think we can do something more like: https://github.com/bitshares/bitshares-ui/blob/develop/LICENSE.md for the header.

@oxarbitrage
Copy link
Member

@ryanRfox do you want to take a look into this comments #1525 (comment) ? I can remove the changes needed and merge as it is now if you think is the best.

thank you.

@ryanRfox
Copy link
Contributor Author

I'm going to request some guidance from @xeroc and @sschiessl-bcp on the proper way to copyright and acknowledge the contributors within our code/files. Sorry, I don't know what is best.

@xeroc
Copy link
Member

xeroc commented Jan 31, 2019

python-bitshares uses an AUTHORS file that is automatically created by this Makefile entry

Could do the same with contributors

@sschiessl-bcp
Copy link

I like that script from Fabian. Nevertheless, in the UI repository we have
"Copyright (c) 2019 The BitShares UI worker and and contributors."

@ryanRfox
Copy link
Contributor Author

I too like that makefile script > AUTHORS provided by @xeroc . However, I don't see the linkage between that file and the LICENSE file. I was expecting the Copyright therein to reference the AUTHORS file. Referencing the Core WP feels to vague for a copyright. I remain open to identifying what the best solution may be.

@xeroc
Copy link
Member

xeroc commented Feb 1, 2019

Worth a read:

There's a difference between licensing code to you and assigning copyright to you, and in this case the code is licensed to you while the contributor still holds the copyright.

Since their contributions are under the MIT license, though, you can later apply a different license to the combined work, as long as you preserve their copyright notice and the MIT license.

Hence, for a project that has a central LICENSE file but many contributors, it makes sense to have the copyright notice declare that many contributors are owners of the code.

Examples:

  • Copyright Node.js contributors. All rights reserved.
  • Copyright (C) 2012-2018 by various contributors (see AUTHORS)
  • Copyright (c) 2007 - 2018, Daniel Stenberg with many contributors, see AUTHORS file.
  • Copyright Joyent, Inc. and other Node contributors.
  • Copyright (c) 2015-present libuv project contributors.
  • Copyright (c) 1998-2018 The OpenSSL Project. All rights reserved.

It may make sense to cleanup the code and remove the license boilerplate in favor of having a central spot for the license anyways.

@ryanRfox
Copy link
Contributor Author

ryanRfox commented Feb 1, 2019

Thanks @xeroc for the references. I'll read up and determine more holistically how we will maintain our attributions. Moving this to the next Feature Release.

@pmconrad
Copy link
Contributor

  • Rebased on latest develop
  • added CONTRIBUTORS.txt as suggested by @xeroc
  • added .mailmap file for merging commits from the same person with different name/email
  • assigned copyright to BBF

Question: what about license headers in individual source files?

@abitmore abitmore changed the title Update copyright for 2019 (develop) Update copyright for 2020 (develop) Jan 30, 2020
@abitmore abitmore dismissed oxarbitrage’s stale review January 30, 2020 10:37

too old, no feedback

abitmore
abitmore previously approved these changes Jan 30, 2020
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for progress.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for progress.

@abitmore abitmore changed the title Update copyright for 2020 (develop) Update copyright for 2020 Jan 30, 2020
@abitmore abitmore merged commit 7fe004f into develop Jan 30, 2020
@abitmore abitmore deleted the copyright-update-develop branch January 30, 2020 12:53
@abitmore abitmore restored the copyright-update-develop branch June 25, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants