-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright for 2020 #1525
Conversation
@@ -1,5 +1,5 @@ | |||
Copyright (c) 2015-2016 Cryptonomex Inc. <contact@cryptonomex.com> | |||
Copyright (c) 2015-2017 contributors <CONTRIBUTORS.txt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We have 2 lines of Copyright ?
- We have a reference to CONTRIBUTORS.txt witch is empty.
I think we can do something more like: https://github.com/bitshares/bitshares-ui/blob/develop/LICENSE.md for the header.
@ryanRfox do you want to take a look into this comments #1525 (comment) ? I can remove the changes needed and merge as it is now if you think is the best. thank you. |
I'm going to request some guidance from @xeroc and @sschiessl-bcp on the proper way to copyright and acknowledge the contributors within our code/files. Sorry, I don't know what is best. |
python-bitshares uses an AUTHORS file that is automatically created by this Makefile entry Could do the same with contributors |
I like that script from Fabian. Nevertheless, in the UI repository we have |
I too like that makefile script > AUTHORS provided by @xeroc . However, I don't see the linkage between that file and the LICENSE file. I was expecting the Copyright therein to reference the AUTHORS file. Referencing the Core WP feels to vague for a copyright. I remain open to identifying what the best solution may be. |
Worth a read:
There's a difference between licensing code to you and assigning copyright to you, and in this case the code is licensed to you while the contributor still holds the copyright. Since their contributions are under the MIT license, though, you can later apply a different license to the combined work, as long as you preserve their copyright notice and the MIT license. Hence, for a project that has a central LICENSE file but many contributors, it makes sense to have the copyright notice declare that many contributors are owners of the code. Examples:
It may make sense to cleanup the code and remove the license boilerplate in favor of having a central spot for the license anyways. |
Thanks @xeroc for the references. I'll read up and determine more holistically how we will maintain our attributions. Moving this to the next Feature Release. |
1934b0b
to
cd334d0
Compare
Question: what about license headers in individual source files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for progress.
Update copyright to cover 2020. For issue #1524.