Add validation to HTLC Extend #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
Apr 4, 2019
17 tasks
abitmore
reviewed
Apr 5, 2019
|
|
||
| account_id_type fee_payer()const { return to; } | ||
| void validate()const { FC_ASSERT( !"virtual operation" ); } | ||
|
|
||
| share_type calculate_fee(const fee_parameters_type& k)const { return 0; } | ||
|
|
||
| htlc_id_type htlc_id; | ||
| account_id_type from, to; | ||
| account_id_type from, to, redeemer; |
There was a problem hiding this comment.
I think we need to bump DB_VERSION if to add a field here.
There was a problem hiding this comment.
I disagree. We don't have any such operations in the database yet, therefore the change has no effect. We can avoid the replay.
(If you agree please drop the last two commits and force-push instead of reverting.)
There was a problem hiding this comment.
We can do the bump for testnet branch only.
jmjatlanta
force-pushed
the
jmj_htlc_hotfix
branch
from
bd7634e to
8f5dddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696