HTLC API Additions #1742
Merged
HTLC API Additions #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
commented
Apr 29, 2019
| @@ -340,6 +340,9 @@ void application_impl::set_api_limit() { | |||
| if(_options->count("api-limit-get-key-references")){ | |||
| _app_options.api_limit_get_key_references = _options->at("api-limit-get-key-references").as<uint64_t>(); | |||
| } | |||
| if(_options->count("api-limit-get-htlc-by")) { | |||
| _app_options.api_limit_get_htlc_by = _options->at("api-limit-get-htlc-by").as<uint64_t>(); | |||
There was a problem hiding this comment.
I would have liked a more descriptive name for this, and have it cover both "to" and "from", but I could not think of one.
Closed
pmconrad
reviewed
Apr 30, 2019
tests/tests/htlc_tests.cpp
Outdated
| BOOST_CHECK_EQUAL( full[alice.name].htlcs.size(), 3 ); | ||
|
|
||
| full = db_api.get_full_accounts({bob.name}, false); | ||
| BOOST_CHECK_EQUAL( full[alice.name].htlcs.size(), 0 ); |
There was a problem hiding this comment.
This should be bob.name, and the count shouldn't be 0.
pmconrad
reviewed
Apr 30, 2019
tests/tests/htlc_tests.cpp
Outdated
| // alice puts a htlc contract to bob | ||
| { | ||
| graphene::chain::htlc_create_operation create_operation; | ||
| BOOST_TEST_MESSAGE("Alice (who has 100 coins, is transferring 2 coins to Bob"); |
There was a problem hiding this comment.
Actually she's transferring 3 not 2 (same in the other cases)
pmconrad
approved these changes
Apr 30, 2019
|
nice work @jmjatlanta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes of PR #1729, along with fixes requested in that PR.
In short, this PR fixes #1713