Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix market ticker volume underflow issue #1885

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Aug 6, 2019

PR for #1883.

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Aug 6, 2019
@abitmore abitmore mentioned this pull request Aug 6, 2019
17 tasks
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @abitmore . thank you.

Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely found, nicely fixed. Thanks!

@oxarbitrage oxarbitrage merged commit 90fd510 into develop Aug 8, 2019
@abitmore abitmore deleted the pr-1883-fix-ticker-rolling branch August 14, 2019 19:57
abitmore added a commit that referenced this pull request Aug 18, 2019
Due to #1885, need to force a replay.
This was referenced Aug 18, 2019
jmjatlanta pushed a commit that referenced this pull request Sep 3, 2019
Due to #1885, need to force a replay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants