-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database_api code refactory #1891
Conversation
Nice stuff, in the right direction. For continuation in new lines of functions with arguments i personally prefer to use double indentation(6 spaces in our codebase) as sometimes the namespace, type, name, etc can be so long that you will have little space to place the arguments if you place them one below the other aligned. I see you applied some of that in some cases(where you didn't had another option) with more than 6 spaces. 6 spaces will kind of work always, if more then 2 lines are needed i do something like: bitshares-core/libraries/plugins/elasticsearch/elasticsearch_plugin.cpp Lines 541 to 545 in f1bedc7
|
c7d657a
to
fa42e70
Compare
Rebased to latest |
Move market_ticket constrctors to api_objects.cpp; move price_to_string(...) to util.hpp and util.cpp.
98de678
to
d51305c
Compare
Updated text about copyright and force-pushed to avoid having confusing copyright changes in history. Updated includes, built fine with GCC5.4 in Ubuntu 16.04, not sure whether there would be issue on other platforms. |
d51305c
to
62fc622
Compare
Changes:
price_to_string()
from database_api.* to util.*database_api_impl
class into itPutting this in 3.3 release so far, please feel free to move out if it's not appropriate.