Reset flag after testing compiler #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
reviewed
Aug 20, 2019
pmconrad
modified the milestones:
4.1.0 - Feature Release,
4.0.0 - Protocol Upgrade Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake fails on macOS due to unable to find pthread.h. This is caused by previous tests adjusting CMAKE_REQUIRED_FLAGS and not resetting them. This change resets CMAKE_REQUIRED_FLAGS after the tests complete.
NOTE: There is a "sister" change in fc. See bitshares/bitshares-fc#149
As this change affects positioning in libraries, testing configurations that use shared libraries is important.