Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly list cpp files for building wallet lib, fix Gitian build #2198

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

abitmore
Copy link
Member

The Linux build was not reproducible due to the unstable ordering of source files for building the graphene_wallet library. This PR fixes it.

See bitshares/bitshares-gitian#38.

@abitmore
Copy link
Member Author

abitmore commented Jun 16, 2020

Strange, Travis failed on push:

/home/travis/build/bitshares/bitshares-core/tests/tests/htlc_tests.cpp(787): error in "htlc_hardfork_test": check good_proposal_id(db).is_authorized_to_execute(db) failed

/home/travis/build/bitshares/bitshares-core/tests/tests/htlc_tests.cpp(807): error in "htlc_hardfork_test": check db.get_global_properties() .parameters.extensions.value.updatable_htlc_options->max_preimage_size == 2048u failed [19200 != 2048]

Will rerun.

Update: Travis passed on rerun.

Note: I found the htlc_hardfork_test test case does contain an issue, better clear trx before adding the proposal_update operation, but I don't think it caused the last failure.

trx.operations.push_back(uop);
sign( trx, init_account_priv_key );
db.push_transaction(trx);
BOOST_CHECK(good_proposal_id(db).is_authorized_to_execute(db));

@abitmore abitmore merged commit e22436f into release Jun 16, 2020
@abitmore abitmore deleted the fix-gitian-ubuntu-cli branch June 16, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant