-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add liquidity pool statistics and new APIs #2297
Conversation
49ecf7f
to
7c4d092
Compare
5cc05fd
to
e586046
Compare
032e5b8
to
6d87ac2
Compare
and add a get_liquidity_pools API
- get_liquidity_pool_history - get_liquidity_pool_history_by_sequence
6d87ac2
to
80fe3cb
Compare
The bucket logic hasn't been done for liquidity pools. What you have are described in OP. |
Are there any plans to add it with next API upgrade, or would you oppose a PR adding it? |
@sschiessl-bcp No plan yet. Just haven't got time, and didn't see a strong use case. If you really want it, I can add it when got time. |
No, not hard. But then all existing code that works with market history is directly compatible, which would be nice. For the explorer, I recreated it now, just FYI |
For issue #2280.
with_statistics
parameterlist_liquidity_pools( limit, start_pool_id, with_statistics )
get_liquidity_pools_by_asset_a( asset, limit, start_pool_id, with_statistics )
get_liquidity_pools_by_asset_b( asset, limit, start_pool_id, with_statistics )
get_liquidity_pools_by_both_assets( asset_a, asset_b, limit, start_pool_id, with_statistics )
get_liquidity_pools_by_share_asset( assets_vector, subscribe, with_statistics )
get_liquidity_pools_by_owner( account, limit, start_share_asset_id, with_statistics )
get_liquidity_pools( pool_IDs, subscribe, with_statistics )
history_api::get_liquidity_pool_history( pool_id, start_time, stop_time, limit, operation_type )
history_api::get_liquidity_pool_history_by_sequence( pool_id, start_sequence, stop_time, limit, operation_type )