Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doxygen warnings, remove some unused code #2324

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Jan 6, 2021

PR for #2213.

Bumped FC with bitshares/bitshares-fc#223 .

NOTE:
Item(s) unable to fix so far:

  • warning: documented symbol `graphene::chain::decltype' was not declared or defined on several files
  • warning: no uniquely matching class member found for (some methods in some template classes), E.G.
libraries/fc/include/fc/fwd_impl.hpp:128: warning: no uniquely matching class member found for
  template < T, S, A >
  T & fc::fwd< T, S, A >::operator=(fc::fwd< T, S, A > &&u)
Possible candidates:
  'template < U >
  T & fc::fwd< T, S, Align >::operator=(U &&u)' at line 31 of file /home/ubuntu/bitshares-core-dev/libraries/fc/include/fc/fwd.hpp
  T & fc::fwd< T, S, Align >::operator=(fwd &&u)' at line 33 of file /home/ubuntu/bitshares-core-dev/libraries/fc/include/fc/fwd.hpp
  T & fc::fwd< T, S, Align >::operator=(const fwd &u)' at line 34 of file /home/ubuntu/bitshares-core-dev/libraries/fc/include/fc/fwd.hpp
  • libraries/fc/include/fc/thread/parallel.hpp:91: warning: argument 'desc' of command @param is not found in the argument list of fc::do_parallel(Functor &&f, const char *desc FC_TASK_NAME_DEFAULT_ARG) ->-> fc::future< decltype(f())> (and some other files), and parameter 'FC_TASK_NAME_DEFAULT_ARG' is "not documented"
    • Doxygen thinks FC_TASK_NAME_DEFAULT_ARG is the argument
  • README.md:6: warning: Unexpected html tag <img> found within <a href=...> context
    • The section will be removed from the generated HTML file anyway

@abitmore abitmore added this to the 5.1.0 - Feature Release milestone Jan 6, 2021
@abitmore abitmore linked an issue Jan 6, 2021 that may be closed by this pull request
17 tasks
@abitmore abitmore marked this pull request as ready for review January 7, 2021 14:05
@abitmore abitmore merged commit 197d904 into develop Jan 8, 2021
@abitmore abitmore deleted the fix-doxygen-warnings branch January 8, 2021 16:06
@abitmore abitmore mentioned this pull request Jan 8, 2021
17 tasks
@abitmore abitmore removed a link to an issue Jan 8, 2021
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant