Fix object slicing warnings, duplicate code and some other code smells #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
fix-object-slicing
branch
from
50b52a1 to
eecafbb
Compare
abitmore
changed the title
Fixes an object slicing warning.
by calling borrow_asset_ext(...) directly.
abitmore
force-pushed
the
fix-object-slicing
branch
from
eecafbb to
988c19f
Compare
by checking more directories with gcov
abitmore
force-pushed
the
fix-object-slicing
branch
from
5657c4a to
7032a8e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2101.