Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default es-objects-max-mapping-depth to 10 #2616

Merged
merged 1 commit into from
Jul 27, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libraries/plugins/es_objects/es_objects.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ class es_objects_plugin_impl

std::string index_prefix = "objects-";

/// For the "index.mapping.depth.limit" setting in ES. The default value is 20.
uint16_t max_mapping_depth = 20;
/// For the "index.mapping.depth.limit" setting in ES whose default value is 20,
/// and need to be even smaller to not trigger the index.mapping.total_fields.limit error
uint16_t max_mapping_depth = 10;

uint32_t start_es_after_block = 0;
bool sync_db_on_startup = false;
Expand Down Expand Up @@ -390,7 +391,8 @@ void es_objects_plugin::plugin_set_program_options(
("es-objects-index-prefix", boost::program_options::value<std::string>(),
"Add a prefix to the index(objects-)")
("es-objects-max-mapping-depth", boost::program_options::value<uint16_t>(),
"The maximum index mapping depth (index.mapping.depth.limit) setting in ES (20)")
"Can not exceed the maximum index mapping depth (index.mapping.depth.limit) setting in ES, "
"and need to be even smaller to not trigger the index.mapping.total_fields.limit error (10)")
("es-objects-keep-only-current", boost::program_options::value<bool>(),
"Deprecated. Please use the store-updates or no-delete options. "
"Keep only current state of the objects(true)")
Expand Down