Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify inbound endpoints as soon as possible #2640

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Verify inbound endpoints as soon as possible #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51ced00
Verify inbound endpoints as soon as possible
abitmore Sep 15, 2022
cce5650
Fix a code smell
abitmore Sep 15, 2022
d331b4a
Review inbound peer's inbound endpoint
abitmore Sep 15, 2022
0090b1f
Fix a code smell
abitmore Sep 15, 2022
326d44e
Guess inbound endpoint early to avoid revisiting
abitmore Sep 15, 2022
f7023e5
Simplify code
abitmore Sep 15, 2022
28704f1
Remove redundant member: inbound_endpoint_verified
abitmore Sep 15, 2022
120ea6f
Avoid unnecessary copying of data
abitmore Sep 15, 2022
c0174e8
Fix a code smell
abitmore Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libraries/net/include/graphene/net/peer_connection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,12 +195,12 @@ namespace graphene { namespace net
fc::ip::address inbound_address;
uint16_t inbound_port = 0;
uint16_t outbound_port = 0;
/// The inbound endpoint of the remote peer
/// The inbound endpoint of the remote peer (our best guess)
fc::optional<fc::ip::endpoint> remote_inbound_endpoint;
/// Whether the inbound endpoint of the remote peer is verified
bool inbound_endpoint_verified = false;
/// Some nodes may be listening on multiple endpoints
fc::flat_set<fc::ip::endpoint> additional_inbound_endpoints;
/// Potential inbound endpoints of the peer
fc::flat_map<fc::ip::endpoint, firewalled_state> potential_inbound_endpoints;
/// @}

using item_to_time_map_type = std::unordered_map<item_id, fc::time_point>;
Expand Down
Loading