Update Dockerfile and build-docker workflow #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
changed the title
abitmore
force-pushed
the
update-build-docker
branch
from
45e0874 to
97cb479
Compare
abitmore
force-pushed
the
update-build-docker
branch
from
97cb479 to
6abef18
Compare
- Set UID to 10000 and GID to 10001 statically - Run with the bitshares user
This is a temporary solution compatible with older images.
abitmore
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
mellertson
reviewed
Nov 27, 2022
| # | ||
| # Obtain version | ||
| mkdir -p /etc/bitshares && \ | ||
| git rev-parse --short HEAD > /etc/bitshares/version && \ | ||
| cd / && \ | ||
| rm -rf /bitshares-core | ||
|
|
||
| # Home directory $HOME | ||
| # The final image |
There was a problem hiding this comment.
I like how you separated the build and runtime envionronments. Should make the final image smaller with fewer attack vectors.
mellertson
reviewed
Nov 27, 2022
| # default execute entry | ||
| CMD ["/usr/local/bin/bitsharesentry.sh"] | ||
| ENTRYPOINT ["/usr/local/bin/bitsharesentry.sh"] |
There was a problem hiding this comment.
Good idea to use an ENTRYPOINT VS a CMD.
mellertson
reviewed
Nov 27, 2022
| # Plugins need to be provided in a space-separated list, which | ||
| # makes it necessary to write it like this | ||
| if [[ ! -z "$BITSHARESD_PLUGINS" ]]; then | ||
| exec "$BITSHARESD" --data-dir "${HOME}" ${ARGS} ${BITSHARESD_ARGS} --plugins "${BITSHARESD_PLUGINS}" | ||
| exec /usr/bin/setpriv --reuid=bitshares --regid=bitshares --clear-groups \ |
There was a problem hiding this comment.
Are you using setpriv here as part of the temp workaround related to commenting out line 111 above?
There was a problem hiding this comment.
Yes, setpriv is used here to drop root privileges. For this, it is better than su.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2011.
Changes:
bitsharesuser whose UID is statically set to10000and GID to10001, to follow best practices https://github.com/hexops/dockerfile#use-a-static-uid-and-gid.major.minorversion tag to Docker Hub too, to follow best practices https://github.com/hexops/dockerfile#do-not-use-latest-pin-your-image-tagsbuild-dockerworkflow to a variable instead of hardcoding it.