-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #2784
Fix typos #2784
Conversation
Hi @omahs, thanks for the pull request. I noticed that you create a lot of "fix typos" pull requests in a lot of different repositories, do you use a bot to scan the repositories for spelling issues? To be honest, this looks suspicious. By default, pull requests from first-time contributors require approval from a maintainer to start CI tests. One potential risk is that if someone submits a small pull request before submitting a second with malicious code, this would automatically run all configured workflows because that person is no longer a first-time contributor. I'm not saying you will do this, but for security reasons I won't merge this pull request. Hope you can understand. Thank you anyway. |
Hey @abitmore, Thanks for your message. I don't use bots but generally check documentation files (.md, .rst, .mdx…) for spelling mistakes. |
Thanks for the clarification. Just out of curiousity, if you're not using bots, I guess you must be using some efficient tools, right? According to your Github profile, during this month, you created 208 commits in 104 repositories and opened another 181 pull requests in 170 repositories, which I don't think a human who "generally checks documentation files" can achieve manually. And the tools must be very smart, as in oceanbase/oceanbase#1577 it can even fix typos in comments and log messages in the source code (.h and .cpp files). |
@abitmore I legit use only basic tools, like the github search feature and grammarly. I actually wish I was able to code something efficient for a better workflow. If I had such a bot I would then be able to find way more misspellings. I do dedicate a lot of time to this though and I know it's unusual. |
Hi @omahs, that might have taken you a lot of time. Thank you anyway.
|
Thanks https://github.com/omahs for #2784
Thanks to https://github.com/omahs for #2784
Thanks to https://github.com/omahs for #2784
Fix typos