Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More simplifications #137

Merged
merged 25 commits into from
Jun 19, 2019
Merged

More simplifications #137

merged 25 commits into from
Jun 19, 2019

Conversation

pmconrad
Copy link

@pmconrad pmconrad commented Jun 9, 2019 •
edited
Loading

"Resolves" bitshares/bitshares-core#1584 and bitshares/bitshares-core#998 after core PR merged.
Requires additional changes in Core, see bitshares/bitshares-core#1789

pmconrad added 17 commits May 29, 2019 11:28
@pmconrad
Replaced most fc::shared_ptr with std::shared_ptr
58e16e5
@pmconrad
Intermediate
7cf3717
@pmconrad
Added retain where applicable
19bbc40
@pmconrad
Moved retain/release to task_base
7506aae
@pmconrad
Removed unused real128
022c40d
@pmconrad
Remove unused header
648d969
@pmconrad
Replace fc::uint128 with boost::multiprecision::uint128_t
a3e2410
@pmconrad
Replace fc::array with std::array
632a907
@pmconrad
Added constexpr where applicable
a8337ec
@pmconrad
Replaced fc::forward with std::forward
0aac8a4
@pmconrad
Replaced fc::deduce with std::remove_reference<std::remove_const<>>
8ad041c
@pmconrad
Replaced fc::nullptr_t with std::nullptr_t
1025c36
@pmconrad
Replace NO_RETURN with [[noreturn]] standard attribute
f732a58
@pmconrad
Replaced true_type, false_type, is_class, is_enum with std type_traits
a11a50d
@pmconrad
Added fc::int128_t
8196eb9
@pmconrad
Removed broken http_server + unused http_api
7649f1f
@pmconrad
Add support for native 128bit types
79b2a0d
@pmconrad pmconrad mentioned this pull request Jun 9, 2019
Merged
@abitmore
Copy link
Member

The Travis CI build failed.

abitmore
abitmore reviewed Jun 10, 2019
View reviewed changes
include/fc/thread/parallel.hpp Outdated Show resolved Hide resolved
include/fc/thread/thread.hpp Outdated Show resolved Hide resolved
include/fc/thread/thread.hpp Outdated Show resolved Hide resolved
include/fc/thread/task.hpp Outdated Show resolved Hide resolved
include/fc/variant.hpp Outdated Show resolved Hide resolved
include/fc/variant.hpp Outdated Show resolved Hide resolved
include/fc/variant.hpp Outdated Show resolved Hide resolved
include/fc/variant.hpp Outdated Show resolved Hide resolved
src/crypto/city.cpp Outdated Show resolved Hide resolved
src/io/fstream.cpp Show resolved Hide resolved
@pmconrad
Copy link
Author

Travis failure seems to be due to a gcc bug. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66297
Will undo for better compatibility and because the constexpr make little sense there. Hm, or perhaps make size a static member function?

abitmore
abitmore previously approved these changes Jun 18, 2019
View reviewed changes
nathanielhourt
nathanielhourt suggested changes Jun 19, 2019
View reviewed changes
Copy link

@nathanielhourt nathanielhourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks, and some questions

include/fc/thread/task.hpp Outdated Show resolved Hide resolved
include/fc/thread/task.hpp Outdated Show resolved Hide resolved
include/fc/variant.hpp Show resolved Hide resolved
src/thread/thread_d.hpp Outdated Show resolved Hide resolved
nathanielhourt
nathanielhourt approved these changes Jun 19, 2019
View reviewed changes
Copy link

@nathanielhourt nathanielhourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pmconrad pmconrad merged commit 6ed9431 into bitshares:master Jun 19, 2019
@pmconrad pmconrad deleted the 1584_more_simplification branch June 19, 2019 16:35
@pmconrad pmconrad mentioned this pull request Jun 20, 2019
Closed
@MichelSantos MichelSantos mentioned this pull request Aug 9, 2019
Closed
@abitmore abitmore added this to the core release 3.3.0 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielhourt nathanielhourt nathanielhourt approved these changes

@abitmore abitmore abitmore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
core release 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @abitmore @nathanielhourt