[6][startailcoon] Show more info on asset info page

[abitmore]

It's now calculated as settlement_price / MCR, but should be settlement_price * MSSR / MCR.
Update: see this comment below.

[startailcoon]

I can take this task. I think it's worth adding some more parameters at the same time, like offset percentage, and possibly some more.

[abitmore]

Actually it's a bit complicated.
The global settlement price is actually correct, but a global settlement (black swan) will trigger at 10% (which is MSSR) above that price.
So what should the UX be?

[abitmore]

Oh wait, does that "settlement price" include offset? My calculation above didn't count in the offset. I mean, median feed price is a thing, price for force settlement is another.

[startailcoon]

The field Global Settlement Price isn't provided by something from the chain in the GUI, but a manual calculation of debt and collateral. I will require some help to provide if this is correct, or requires some new way of calculation.

Code

bitshares-ui/app/components/Blockchain/Asset.jsx

Lines 564 to 611 in 33a0832

	getGlobalSettlementPrice() {
	var call_orders;
	if (!this.state.callOrders) {
	return null;
	} else {
	// put the call order on the stack
	call_orders = this.state.callOrders;
	}
	// first get the least collateralized short position
	var leastColShort = null;
	var leastColShortRatio = null;
	var len = this.state.callOrders.length;
	for (var i = 0; i < len; i++) {
	let call_order = this.state.callOrders[i];
	if (leastColShort == null) {
	leastColShort = call_order;
	leastColShortRatio = call_order.getRatio();
	} else if (call_order.getRatio() < leastColShortRatio) {
	leastColShortRatio = call_order.getRatio();
	leastColShort = call_order;
	}
	}
	if (leastColShort == null) {
	// couldn't find the least colshort?
	console.log("couldn't find the least col short");
	return null;
	}
	// this price will happen when the CR is 1.
	// The CR is 1 iff collateral / (debt x feed_ price) == 1
	// Rearranging, this means that the CR is 1 iff
	// feed_price == collateral / debt
	let debt = leastColShort.amountToReceive().getAmount();
	let collateral = leastColShort.getCollateral().getAmount();
	let globalSettlementPrice = collateral / debt;
	return (<FormattedPrice
	base_amount={collateral}
	base_asset={leastColShort.call_price.base.asset_id}
	quote_amount={debt}
	quote_asset={leastColShort.call_price.quote.asset_id}
	/>);
	}

but a global settlement (black swan) will trigger at 10% (which is MSSR) above that price.

I assume your wish is to display when a market is possibly going to be affected by a black swan event? I will require some more details and a few example on this matter to be able to add in something useful, and hopefully not to confusing for users.

The market details page could, and should imho, have more technical details for traders to analyze the market.

[startailcoon]

Releasing this for anyone interested in following up on this for now.

[startailcoon]

Ping @abitmore. Can you enlighten us about my question from before?

[abitmore]

IMHO it needs UX. We have all the data, need to decide how to non-misleadingly show them.

[abitmore]

All prices described below are in terms of debt/collateral, aka how much debt per collateral, which may affect descriptive words like "below", "above", "lower than", "higher than", "min", "max" and etc. If the price in UI is flipped, corresponding words need to be flipped as well.

We have these data, need to show some or all of them:

• price feeds: a list, published by witnesses or other price feed producers
  • feed producer
  • price
  • CER
  • MCR
  • MSSR
• medians (already calculated by server, so get from bitasset data directly):
  • median price feed (showing as settlement price in OP): median of price feeds
  • median MCR
  • median MSSR
• about force settlement:
  • offset
  • delay
  • max settle-able volume per maintenance interval (percent)
  • force settle price: median price feed * ( 100% + offset ), the price that a force settlement order will be filled at
  • max settle-able volume before next maintenance interval (absolute value): total supply * percent
  • settled volume: amount settled in this maintenance interval
  • remaining settle-able volume: max - settled
• about margin calls:
  • MSSP: median price feed / MSSR, the lowest price that a margin call can be executed at
• short positions (list):
  • user
  • debt amount
  • collateral amount
  • call price: if feed price is below or equal to this value, the order will be able to be margin called
  • collateral ratio: median price feed * collateral / debt
• about black swan event (if an asset is not in black swan state): calculate from the short position with least collateral ratio (affected by this bug: Black swan detection checks short position with lowest call_price but not lowest collateral ratio bitshares-core#649, a black swan event can be deferred)
  • black swan price: MSSR * debt / collateral, if feed price is below this value, a black swan event may occur
• if an asset is in black swan state (e.g. GOLD):
  • global settlement price: a new settlement order will execute at this price immediately (won't delay)
  • settlement fund: how much collateral is available (should be equal to current supply / global settlement price)
  • a list of collateral bids
    • user
    • additional collateral amount: how much collateral the user wants to add
    • debt amount: how much debt the user wants to cover/claim

[wmbutler]

This needs UX, @ahdigital ?

[grctest]

''bitGOLD' which is currently in a global settlement state has a global settlement value of '-'. If you navigate from bitUSD to bitGOLD via the URL bar the bitUSD value stays until you refresh the page.

In a global settlement state, perhaps it'd be worth providing BSIP 18 related UI elements - indicating how close it is to leaving the global settlement state (and perhaps a link to docs explaining the situation/state bitGOLD is in)?

[wmbutler]

@startailcoon I think we need to get this to a closing point.

[startailcoon]

@startailcoon I think we need to get this to a closing point.

I tend to agree :)

I know alot more today, and I hope to be able to close this soon.

[wmbutler]

So, when you are ready to bring it to a close, make a second issue with the remaining points and close this out. Nice work.

[startailcoon]

I've posted an issue on bitshraes-core to include asset collateral volume and settled volume on chain.

bitshares/bitshares-core#1448

[startailcoon]

Adding a few new fields

Price Feed

Settlement (normal)

Settlement (in Global Settlement)

I'm not sure if the Settlement Volume will change during a global settlement.

[abitmore]

Due to bsip42, the name "external price" is not so good. #1865.

Volume limit is ignored after globally settled.

[startailcoon]

@abitmore noted. Removing volume limit data on global settled asset.

Due to bsip42, the name "external price" is not so good

How is "Average market price"?

[sschiessl-bcp]

How is "Average market price"?

How about waht it actually is: Feed price (median of witness feeds)

[sschiessl-bcp]

I did not read the discussion in here in detail beforehand and rearranged a bit, sorry. Can you please check if appropriate

USD

CNY

[startailcoon]

Looks good to me