Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5] Update account history object sorting logic #2545

Closed
abitmore opened this issue Mar 24, 2019 · 3 comments · Fixed by #2646
Closed

[0.5] Update account history object sorting logic #2545

abitmore opened this issue Mar 24, 2019 · 3 comments · Fixed by #2646
Assignees
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone

Comments

@abitmore
Copy link
Member

Describe the bug
Current code for sorting account history object will be obsolete after bitshares/bitshares-core#1675 is done.

function compareOps(b, a) {
if (a.block_num === b.block_num) {
return a.virtual_op - b.virtual_op;
} else {
return a.block_num - b.block_num;
}
}

The correct logic is to compare all the 4 fields (block_num, trx_in_block, op_in_trx, virtual_op) in the object (it is also correct before bitshares/bitshares-core#1675 is done).

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@startailcoon startailcoon added [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [6] Core Impact flag identifying related to bitshares-core [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [5b] Small Indicates size of task. Est. between one and two hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Mar 24, 2019
@startailcoon startailcoon added this to the 190412 milestone Mar 24, 2019
@startailcoon startailcoon changed the title Update account history object sorting logic [1.5] Update account history object sorting logic Mar 24, 2019
@sschiessl-bcp sschiessl-bcp self-assigned this Apr 4, 2019
@alexandr-masl
Copy link
Contributor

hi everyone, can I take this one.
thanks in advance.

@startailcoon
Copy link
Contributor

startailcoon commented Apr 14, 2019

@alexandr-masl, @sschiessl-bcp already has this claimed and fixed.

The changes mentioned will be live in version 3.1.0, Testnet relase 16 April, and main network release 30 April.

Make sure to check if it's required to keep backwards compatibility.

@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Apr 14, 2019

There is already a PR for this one in our repo, will be forwarded after RC is done

@startailcoon startailcoon changed the title [1.5] Update account history object sorting logic [0.5] Update account history object sorting logic Apr 14, 2019
@startailcoon startailcoon modified the milestones: 190426, 190510 Apr 28, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 190510, 190426 Apr 30, 2019
sschiessl-bcp pushed a commit that referenced this issue Apr 30, 2019
…story_object_sorting_logic

#2545 Added new sortig parametrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants