Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSIP58 #137

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Add BSIP58 #137

merged 4 commits into from
Jan 23, 2019

Conversation

ryanRfox
Copy link
Contributor

Please use this Discussion to add comments (not within this PR).

Copy link
Contributor

@bitcrab bitcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add below at the end of "Specification" part:

This BSIP provide a general solution that handle the bad debt problem of smartcoins, whether this BSIP will be applied to one specific smartcoin depend on the poll voting result, two poll worker proposals, including FOR and AGAINST, will be created for voting on each specific smartcoin.

@xeroc xeroc self-requested a review January 21, 2019 12:06
Copy link
Member

@xeroc xeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this seems to be confirm with the rules of BSIPs.

Ideally, we'd see a paragraph that explains potential risks of this approach to let voters make better decisions.

Copy link
Contributor

@bitcrab bitcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add below as "potential risk" if necessary.

One risk is that this BSIP may be misinterpreted as “price manipulation” or even “cheating” and hurt the trust on smart coin.

Actually this BSIP may lead to obvious higher feed price than market price when bad debt emerge, but this do not lead to hurting to traders comparing to global settlement. The key point is that under this BSIP the global settlement price and also the feed price can still come down, however under global settlement the settle price will be fixed.

To the traders that issue force settlement, this BSIP can provide better price for smartcoin holders to settle.

To the smartcoin holders, this BSIP can bring less devaluing of the smartcoin comparing to global settlement.

The only groups that may be hurt is the debt position owners, their debt position may be settled at a lower price comparing to global settlement, but this is fair and is irrelevant to “price manipulation” or “cheating”.

@xeroc
Copy link
Member

xeroc commented Jan 23, 2019

@ryanRfox can you add Jerry's proposal to the pull request, please?

@ryanRfox ryanRfox merged commit 9ee67b8 into bitshares:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants