Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macro for implementations of ops traits on references #585

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

tim-blackbird
Copy link
Contributor

@tim-blackbird tim-blackbird commented Nov 10, 2024

I added a naive snake_case filter to tera to avoid needing to specify the method name at every macro invocation.

The macros itself is.. pretty gross, as expected.

There is only a slight aesthetic change to the generated code. Self to {{ self_t }} for the XXXAssign ops.

@tim-blackbird tim-blackbird changed the title Use macro for ops traits reference implementations Use macro for implementations of ops traits on references Nov 10, 2024
@bitshifter
Copy link
Owner

Wow, you've been busy! I will get around to reviewing all of these sometime this week hopefully

Copy link
Owner

@bitshifter bitshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request which I think should result in the generated code being the same, or close to the same.

codegen/templates/macros.rs.tera Show resolved Hide resolved
@bitshifter bitshifter merged commit f07ed2e into bitshifter:main Nov 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants