Merge pull request #317 from bitstadium/feature/remove-deprecated-API

Remove deprecated APIs
bitstadium · Oct 5, 2017 · 0d6e285 · 0d6e285
2 parents 238b962 + 612e30a
commit 0d6e285
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 69 deletions.
diff --git a/hockeysdk/src/main/java/net/hockeyapp/android/ExceptionHandler.java b/hockeysdk/src/main/java/net/hockeyapp/android/ExceptionHandler.java
@@ -39,20 +39,6 @@ public void setListener(CrashManagerListener listener) {
         mCrashManagerListener = listener;
     }
 
-    /**
-     * Save a caught exception to disk.
-     *
-     * @param exception Exception to save.
-     * @param listener  Custom CrashManager listener instance.
-     * @deprecated in 3.7.0-beta.2. Use saveException(Throwable exception, Thread thread,
-     * CrashManagerListener listener) instead.
-     */
-    @Deprecated
-    @SuppressWarnings("unused")
-    public static void saveException(Throwable exception, CrashManagerListener listener) {
-        saveException(exception, null, listener);
-    }
-
     /**
      * Save a caught exception to disk.
      *

diff --git a/hockeysdk/src/main/java/net/hockeyapp/android/UpdateManagerListener.java b/hockeysdk/src/main/java/net/hockeyapp/android/UpdateManagerListener.java
@@ -16,10 +16,13 @@
  **/
 @SuppressWarnings({"WeakerAccess"})
 public abstract class UpdateManagerListener {
+
     /**
      * Return your own subclass of UpdateActivity for customization.
      *
      * @return subclass of UpdateActivity
+     *
+     * @deprecated as of 5.0.0, use {@link #getUpdateFragmentClass()} instead.
      */
     @Deprecated
     @SuppressWarnings("unused")
@@ -112,6 +115,8 @@ public boolean canUpdateInMarket() {
     /**
      * Called when the update permissions had not been granted.
      * Implement your custom action to override the default behavior.
+     *
+     * @deprecated as of 5.0.0.
      */
     @Deprecated
     @SuppressWarnings("unused")

diff --git a/hockeysdk/src/main/java/net/hockeyapp/android/metrics/MetricsManager.java b/hockeysdk/src/main/java/net/hockeyapp/android/metrics/MetricsManager.java
@@ -170,41 +170,6 @@ public static void register(Application application, String appIdentifier) {
         register(application, appIdentifier, null, null, null);
     }
 
-    /**
-     * Register a new MetricsManager and collect metrics about user and session.
-     * HockeyApp app identifier is read from configuration values in AndroidManifest.xml.
-     *
-     * @param context     The context to use. Usually your activity.
-     * @param application The application which is required to get application lifecycle
-     *                    callbacks.
-     * @deprecated Use {@link #register(Application)} instead.
-     */
-    @Deprecated
-    @SuppressWarnings("deprecation")
-    public static void register(Context context, Application application) {
-        String appIdentifier = Util.getAppIdentifier(context);
-        if (appIdentifier == null || appIdentifier.length() == 0) {
-            throw new IllegalArgumentException("HockeyApp app identifier was not configured correctly in manifest or build configuration.");
-        }
-        register(context, application, appIdentifier);
-    }
-
-    /**
-     * Register a new MetricsManager and collect metrics about user and session, while
-     * explicitly providing your HockeyApp app identifier.
-     *
-     * @param context       The context to use. Usually your activity.
-     * @param application   The application which is required to get application lifecycle
-     *                      callbacks.
-     * @param appIdentifier Your HockeyApp App Identifier.
-     * @deprecated Use {@link #register(Application, String)} instead.
-     */
-    @SuppressWarnings({"WeakerAccess", "UnusedParameters"})
-    @Deprecated
-    public static void register(Context context, Application application, String appIdentifier) {
-        register(application, appIdentifier, null, null, null);
-    }
-
     /**
      * Register a new MetricsManager and collect metrics information about user and session.
      * Intended to be used for unit testing only.

diff --git a/hockeysdk/src/main/java/net/hockeyapp/android/objects/FeedbackMessage.java b/hockeysdk/src/main/java/net/hockeyapp/android/objects/FeedbackMessage.java
@@ -28,26 +28,6 @@ public class FeedbackMessage implements Serializable {
     private String mAppId;
     private List<FeedbackAttachment> mFeedbackAttachments;
 
-    /**
-     * @return Subject of the feedback message.
-     * @deprecated as of 3.7.0, replaced by {@link #getSubject()}
-     */
-    @Deprecated
-    @SuppressWarnings("SpellCheckingInspection")
-    public String getSubjec() {
-        return mSubject;
-    }
-
-    /**
-     * @param subjec Subject for the feedback message.
-     * @deprecated as of 3.7.0, replaced by {@link #setSubject(String)}
-     */
-    @Deprecated
-    @SuppressWarnings("SpellCheckingInspection")
-    public void setSubjec(String subjec) {
-        this.mSubject = subjec;
-    }
-
     public String getSubject() {
         return mSubject;
     }