This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Fix progress bar #237
Merged
Fix progress bar #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmourat
commented
May 3, 2017
bmourat
commented
- Fixed progress bar bug described here
- Fixed behaviour on configuration change, progress bar stays visible until task finishes.
duchuyctlk
reviewed
May 3, 2017
| private void restoreSendFeedbackTask() { | ||
| Object object = getLastNonConfigurationInstance(); | ||
| if (object != null && object instanceof SendFeedbackTask) { | ||
| mSendFeedbackTask = (SendFeedbackTask) (object); |
There was a problem hiding this comment.
IMO (SendFeedbackTask) object is also fine
There was a problem hiding this comment.
@duchuyctlk you mean we don't need instanceof?
There was a problem hiding this comment.
No. still need. I meant the parenthesis rounding object variable is redundant. 😄
ElektrojungeAtWork
approved these changes
May 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.