Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Fix FeedbackActivity NPE #303

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Fix FeedbackActivity NPE #303

merged 1 commit into from
Sep 20, 2017

Conversation

jaredsburrows
Copy link
Contributor

Issue:

mInitialAttachments in FeedbackActivity is not initialized. Instead of checking, let's make sure it is always non-null.

Error:

java.lang.NullPointerException: Attempt to invoke interface method 'boolean java.util.List.removeAll(java.util.Collection)' on a null object reference
at net.hockeyapp.android.FeedbackActivity$FeedbackHandler.handleMessage(FeedbackActivity.java:849)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

@ElektrojungeAtWork
Copy link
Contributor

Hey!

Good catch and thx for the contribution!

Benny

Copy link
Contributor

@ElektrojungeAtWork ElektrojungeAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Much appreciated!

@ElektrojungeAtWork ElektrojungeAtWork merged commit 5def475 into bitstadium:develop Sep 20, 2017
@jaredsburrows jaredsburrows deleted the jb/fix-FeedbackActivity-npe branch September 20, 2017 17:50
@jaredsburrows
Copy link
Contributor Author

Anytime!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants