[PM-13923] [CLI] fix: resolve CLI file upload issue in Node.js 18+ #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
|
Hi,Is there any progress? @addisonbeck |
addisonbeck
requested review from
coroiu
and removed request for
addisonbeck
coroiu
reviewed
Nov 20, 2024
libs/common/src/platform/services/file-upload/bitwarden-file-upload.service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: xinghejd <31512683+xinghejd@users.noreply.github.com>
|
New Issues
Fixed Issues
|
coroiu
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Fixes #3984
📔 Objective
The file upload judgment logic of the self-hosted version is not rigorous enough, and the upload code in the CLI environment is put into a try-catch block for execution.
Although this could work before Node.js 18, after Node.js 18 introduced built-in Blob objects, it led to delayed error throwing and polluted the fd instance.
Now, it has been replaced with a more explicit judgment statement to distinguish between the browser environment and the CLI environment.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes