[PM-12700] Add private key regeneration process #11829
Conversation
|
New Issues
Fixed Issues
|
|
Looks like those tests are failing on main and aren't related to this PR. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11829 +/- ##
==========================================
+ Coverage 33.45% 33.48% +0.02%
==========================================
Files 2908 2916 +8
Lines 91057 91146 +89
Branches 17336 17349 +13
==========================================
+ Hits 30467 30523 +56
- Misses 58184 58216 +32
- Partials 2406 2407 +1 ☔ View full report in Codecov by Sentry. |
| * Service calls that should be included in this method are only those required to be awaited after successful login. | ||
| * @param userId The user id. | ||
| */ | ||
| abstract run: (userId: UserId) => Promise<void>; |
There was a problem hiding this comment.
🤔 function instead of property ?
There was a problem hiding this comment.
I think this is what you're asking for ? 5466be0
It looks like KM follows a standard, so I swapped to that. In the rest of the code base, they're both used.
Not sure what the difference is?
There was a problem hiding this comment.
Methods declared as arrow functions in an abstract class are treated as properties in TypeScript, not as traditional methods. Generally, we would want actual functions to be treated as functions. It makes things like testing easier as well.
...ser-asymmetric-key-regeneration/abstractions/user-asymmetric-key-regeneration-api.service.ts
Outdated
Show resolved
Hide resolved
...rc/user-asymmetric-key-regeneration/abstractions/user-asymmetric-key-regeneration.service.ts
Outdated
Show resolved
Hide resolved
...ser-asymmetric-key-regeneration/services/default-user-asymmetric-key-regeneration.service.ts
Outdated
Show resolved
Hide resolved
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12700
📔 Objective
Requires server work in bitwarden/server#4929
The purpose of this PR is to add the private key regeneration process on UI refreshed login and lock components.
Old components are out of scope for this feature.
This feature is behind a feature flag.
Target flows are:
Out of scope are the login flows:
Private key regeneration will be added to these once the UI refresh rewrite for them is merged into main in follow-up PRs.
The
LoginSuccessHandlerServicewas the requested approach for the auth team and why it was created under their ownership.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes