Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14406] Handle SyncNotification notification #13135

Closed

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Jan 29, 2025

๐ŸŽŸ๏ธ Tracking

PM-14406

๐Ÿ“” Objective

The associated server change adds a new notification type, the new notification needs to be processed on the client side to avoid any errors.

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ dcfe6977-1039-4399-9b5b-4c3b5b5076c4

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 35.37%. Comparing base (db2b405) to head (07dab60).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13135      +/-   ##
==========================================
- Coverage   35.37%   35.37%   -0.01%     
==========================================
  Files        3010     3010              
  Lines       91176    91177       +1     
  Branches    16996    16996              
==========================================
- Hits        32258    32252       -6     
- Misses      56412    56419       +7     
  Partials     2506     2506              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@nick-livefront nick-livefront marked this pull request as draft January 29, 2025 20:29
@nick-livefront
Copy link
Collaborator Author

There was inflight work that already accomplishes this, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant