Don't use deprecated initKeyEvent() for autofill

[mathewhodson]

This fixes #2000

[CLAassistant]

All committers have signed the CLA.

[jonathonf]

Can confirm this is working with 93.0a1 20210810213316

[streetwolf]

Can I download the version of BW that contains this patch. I use Nightly and really need this.

[jonathonf]

@streetwolf I can send you my unsigned XPI that you can install via about:debugging, though that would be very much an "at your own risk" situation (i.e. how much you can trust a random person on the Web not to steal your passwords versus how difficult it would be to build it yourself).

Edit: Use the official build artefacts instead, #2001 (comment)

[streetwolf]

Sure. Send it my way. I’ll let you know the results.

[MGibson1]

This looks good to me. Thank you, it looks like this has been teetering on the edge of support for a while now.

@cscharf @bitwarden/dept-qa I don't think this is critical to get into this release since the nightly just dropped support (FF nightlies are usually a few months out from stable). However, if you think there's capacity for adding this to the rc branches cut last night it's probably a good addition.

[MGibson1]

Once this is merged into master it should also create build artifacts that can be installed in the same location.

[jonathonf]

@streetwolf I edited in the link in my previous post (notification emails won't show those edits...) so here it is again. :)

Edit: Use the official build artefacts instead, #2001 (comment)

[streetwolf]

So far so good. All my sites can be filled both manually and with autofill. It also seems that the forms are being filled quicker than before.

[cscharf]

@MGibson1 , let's please ensure we have the linked Github issue in Asana and is queued up for testing, but not in rc, we can merge this into master and leave it for the next release. The QA team has started regression testing already for the upcoming release.

[denschub]

@MGibson1 just a heads up:

FF nightlies are usually a few months out from stable

Nightly 93, which breaks Bitwarden, will go into Beta on September 6 and most likely be release on October 5. So that's ~8 weeks.

[cscharf]

Nightly 93, which breaks Bitwarden, will go into Beta on September 6 and most likely be release on October 5. So that's ~8 weeks.

We'll definitely be able to roll it out before then.

[streetwolf]

As already stated the unsigned version with the patch hasn't caused me any problems so far. Nice job. Hope the signed version becomes available soon.

[MGibson1]

We only sign our release builds, but here is the link to the Github actions build for Firefox: https://github.com/bitwarden/browser/suites/3472198561/artifacts/82556656

[streetwolf]

When you release the next update BW as I understand things it will be without this patch. Will there be a way to get the latest BW updates containing the patch or will I have to remain on what I already have? Again many thanks for taking on this issue so quickly.

[MGibson1]

The master branch already contains all the code which will be included in the next release. You've already got the good stuff :)

That being said, please recognize that these non-release builds do not go through our regression testing process and many may be totally untested. Expect more issues than with an actual release build.

[Caspy7]

It was mentioned in another issue but not this one, there is a simpler resolution to this problem: Go to about:config in the URL bar, find dom.keyboardevent.init_key_event.enabled and toggle it to true.

Apparently the deprecated API in question has not been removed from the code yet, just disabled. By the time it is removed, release Bitwarden will [hopefully] have updated to mitigate the issue.

[BBaoVanC]

Was this included in 1.52.0? Firefox auto-updated it to the latest version and autofill stopped working again (but using the artifact mentioned here works)

[denschub]

Was this included in 1.52.0?

No, it was not: https://github.com/bitwarden/browser/blob/v1.52.0/src/content/autofill.js#L843

[bb010g]

How do merges into the rc branch work?

[eliykat]

Thank you @Caspy7 for the workaround. I confirm this wasn't included in 1.52.0 but will be in the following release, per @cscharf's comment above. I don't have an exact date for that release, but it'll be before 5 October, when this breaking change is expected to be released in FF stable.

@bb010g: we develop off the master branch. 1-2 weeks before a release, we cut rc (release candidate) branches for each repo, and those branches are used for regression testing and deployment (not master). The date that we cut rc branches is the effective cut-off date for features and fixes. This issue and fix just happened to come in shortly after we'd cut rc.