Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cipher Decrypt refactor #4473

Closed
wants to merge 2 commits into from
Closed

Cipher Decrypt refactor #4473

wants to merge 2 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 14, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Refactor Ciphers to follow the changes in #3732

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Hinton
Hinton commented Jan 14, 2023
View reviewed changes
libs/common/src/services/cryptography/encrypt.worker.ts
request.view
);

const result = await encryptService.decryptItems(view as any, items as any, key);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out how to get the types here correctly.

differsthecat
differsthecat reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will sends be done in a separate PR?

@Hinton
Copy link
Member Author

Hinton commented Jan 19, 2023 •
edited
Loading

@differsthecat we'll probably try a similar approach as the observable refactors once we're satisfied with the folder and ciphers. (As ciphers are the most complex domain and the others are more similar to folders the rest should hopefully be fairly simple). It's also not time sensitive.

@Hinton Hinton mentioned this pull request Jan 27, 2023
Closed
@MGibson1 MGibson1 self-requested a review April 3, 2023 16:02
@Hinton Hinton closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@differsthecat differsthecat differsthecat left review comments

@MGibson1 MGibson1 Awaiting requested review from MGibson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @differsthecat