Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

[Soft Delete] - Added trash to desktop app #429

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

cscharf
Copy link
Contributor

@cscharf cscharf commented Apr 13, 2020

Objective

This adds the Trash bin and soft-delete/restore functionality to the Desktop client.

Changes

  • ciphers.component.html: Prevent adding a new cipher to the Trash directly
  • groupings.component.html: Added Trash "folder" to top-level groupings navigation
  • vault.component.html: Added vault orchestration event hooks/handlers for deleted and restored items
  • vault.component.ts: Added deleted item view (trash) context tracking and state management. Also managed context menus for items in trash vs. not deleted
  • view.component.html: Added delete and restore buttons

Screenshots

Added the Delete button to the View, and the Trash "folder" to the groupings navigation along with contextual changes for deleted items.
image

Copy link
Member

@kspearrin kspearrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question.

src/app/vault/ciphers.component.html Outdated Show resolved Hide resolved
@cscharf cscharf merged commit e607414 into soft-delete Apr 13, 2020
@cscharf cscharf deleted the soft-delete-chad branch April 13, 2020 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants