Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore and update some more references #349

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Ignore and update some more references #349

merged 1 commit into from
Nov 19, 2024

Conversation

withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Internal change that I just happened to notice.

๐Ÿ“” Objective

Still playing around with the dependency management and thought I would perform some manual updates. Also found one more path to ignore, but I am not sure this is working as expected so it may need a follow-up.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review November 19, 2024 19:09
@withinfocus withinfocus requested a review from a team as a code owner November 19, 2024 19:09
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 3c126174-2a2f-4af5-8f11-cf50210c3f8a

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /workflow-linter.yml: 50

@withinfocus withinfocus merged commit 59f1e79 into main Nov 19, 2024
5 checks passed
@withinfocus withinfocus deleted the updating branch November 19, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants