[PM-7143] Add support for provider side forced uv to support password reprompt

[coroiu]

…ationMethod`

[dani-garcia]

Some general comments, I tried to solve some of the Send+Sync issues by adding some extra bounds. Got it compiling but some tests fail, here's the diff:

diff --git a/passkey-authenticator/src/credential_store.rs b/passkey-authenticator/src/credential_store.rs
index 060c6da..15ce765 100644
--- a/passkey-authenticator/src/credential_store.rs
+++ b/passkey-authenticator/src/credential_store.rs
@@ -14,7 +14,7 @@ use passkey_types::{
 #[async_trait::async_trait]
 pub trait CredentialStore {
     /// Defines the return type of find_credentials(...)
-    type PasskeyItem: TryInto<Passkey> + Clone;
+    type PasskeyItem: TryInto<Passkey> + Send + Clone;
 
     /// Find all credentials matching the given `ids` and `rp_id`.
     ///
diff --git a/passkey-client/src/lib.rs b/passkey-client/src/lib.rs
index 8654d62..1898fb9 100644
--- a/passkey-client/src/lib.rs
+++ b/passkey-client/src/lib.rs
@@ -103,7 +103,7 @@ where
     S: CredentialStore + Sync,
     U: UserValidationMethod + Sync,
     P: public_suffix::EffectiveTLDProvider + Sync + 'static,
-    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem>,
+    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem> + Send + Clone,
 {
     authenticator: Authenticator<S, U>,
     rp_id_verifier: RpIdVerifier<P>,
@@ -113,7 +113,7 @@ impl<S, U> Client<S, U, public_suffix::PublicSuffixList>
 where
     S: CredentialStore + Sync,
     U: UserValidationMethod + Sync,
-    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem>,
+    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem> + Send + Clone,
 {
     /// Create a `Client` with a given `Authenticator` that uses the default
     /// TLD verifier provided by `[public_suffix]`.
@@ -128,9 +128,9 @@ where
 impl<S, U, P> Client<S, U, P>
 where
     S: CredentialStore + Sync,
-    U: UserValidationMethod + Sync,
+    U: UserValidationMethod<PasskeyItem = <S as CredentialStore>::PasskeyItem> + Send + Sync,
     P: public_suffix::EffectiveTLDProvider + Sync + 'static,
-    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem>,
+    Passkey: TryFrom<<S as CredentialStore>::PasskeyItem> + Send + Clone,
 {
     /// Create a `Client` with a given `Authenticator` and a custom TLD provider
     /// that implements `[public_suffix::EffectiveTLDProvider]`.

[coroiu]

point-of-interest: I'm not exactly sure why I had to add mockall and tokio to passkey-client, but it was the only way I could get it to compile after I added #[tokio::test] in authenticator.rs.

[dani-garcia]

The reason they need to be added is that they are declared as dependencies for the two added features:

passkey-rs/passkey-client/Cargo.toml

Lines 18 to 19 in cea73a2

	tokio = ["dep:tokio"]
	testable = ["dep:mockall"]

Those features seem to me like they aren't used anywhere in the passkey-client crate so they can be removed and that means tokio and mockall can be removed from the [dependencies] section.

mockall still needs to be in [dev-dependencies] as it's used here:

passkey-rs/passkey-client/src/tests/mod.rs

Lines 62 to 64 in cea73a2

	mockall::predicate::always(),
	mockall::predicate::eq(true),
	mockall::predicate::eq(true),

[coroiu]

Yeah exactly, but if I do that then those lines give me an error, that's what confuses me

[dani-garcia]

Hmm weird, passkey-authenticator also has them as normal optional dependencies too, so I guess it makes sense to follow that established pattern anyway.

[dani-garcia]

LGTM, just one small nit