Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory_dumping Dockerfile #14

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

dani-garcia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

When we moved bitwarden-sm to bitwarden_license, the memory dump docker tool broke as it was not copying those files over.

Because this is just a local test tool, rather than just copy everything over which would cause frequent cache busting, we can remove the bitwarden_license folder from the workspace.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia requested a review from Hinton October 29, 2024 12:35
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 62.84%. Comparing base (9c30b63) to head (df0cc2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   62.84%   62.84%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
  Hits         7974     7974           
  Misses       4714     4714           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit 3860206 into main Oct 29, 2024
39 checks passed
@dani-garcia dani-garcia deleted the ps/fix-memory-dump-docker branch October 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants