[PM-13376] Phase 2 - SDK split #2

Hinton · 2024-10-21T16:31:53Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13376

📔 Objective

Phase 2 of the SDK repository split.

SDK-internal is a new repository split from the latest main of https://github.com/bitwarden/sdk. It removes all secrets manager language bindings and binaries.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…lit-cleanup # Conflicts: # .github/CODEOWNERS # .github/workflows/build-cli-docker.yml # .github/workflows/build-cli.yml # .github/workflows/build-cpp.yml # .github/workflows/build-dotnet.yml # .github/workflows/build-go.yaml # .github/workflows/build-java.yml # .github/workflows/build-napi.yml # .github/workflows/build-python-wheels.yml # .github/workflows/build-ruby.yml # .github/workflows/build-rust-cross-platform.yml # .github/workflows/build-wasm.yml # .github/workflows/publish-bws.yml # .github/workflows/publish-dotnet.yml # .github/workflows/publish-java.yml # .github/workflows/publish-napi.yml # .github/workflows/publish-php.yml # .github/workflows/publish-python.yml # .github/workflows/publish-ruby.yml # .github/workflows/publish-wasm.yml # .github/workflows/release-bws.yml # .github/workflows/release-cpp.yml # .github/workflows/release-dotnet.yml # .github/workflows/release-go.yml # .github/workflows/release-java.yml # .github/workflows/release-napi.yml # .github/workflows/release-python.yml # .github/workflows/release-wasm.yml # Cargo.lock # crates/bitwarden-wasm-internal/Cargo.toml # crates/bitwarden-wasm/Cargo.toml # crates/bitwarden/CHANGELOG.md # crates/bws/CHANGELOG.md # languages/java/build.gradle # package-lock.json # package.json

github-actions · 2024-10-21T16:34:35Z

Checkmarx One – Scan Summary & Details – 0d4f66e1-1745-43c7-90e8-c9e08123046a

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 44	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 44	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Apt Get Install Pin Version Not Defined	/Dockerfile: 9
	Missing_HSTS_Header	/languages/php/example.php: 3
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
	Privacy_Violation	/languages/java/example/Example.java: 46
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 138
	Privacy_Violation	/languages/java/example/Example.java: 43
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 20
	Privacy_Violation	/languages/java/example/Example.java: 53
	Unpinned Actions Full Length Commit SHA	/release-ruby.yml: 51
	Unpinned Actions Full Length Commit SHA	/release-cpp.yml: 59
	Unpinned Actions Full Length Commit SHA	/release-wasm.yml: 42
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 168
	Unpinned Actions Full Length Commit SHA	/release-cpp.yml: 65
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 172
	Unpinned Actions Full Length Commit SHA	/release-dotnet.yml: 54
	Unpinned Actions Full Length Commit SHA	/build-ruby.yml: 24
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 53
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 162
	Unpinned Actions Full Length Commit SHA	/publish-dotnet.yml: 88
	Unpinned Actions Full Length Commit SHA	/publish-python.yml: 107
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 53
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 130
	Unpinned Actions Full Length Commit SHA	/publish-napi.yml: 110
	Unpinned Actions Full Length Commit SHA	/release-bws.yml: 51
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 92
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 85
	Unpinned Actions Full Length Commit SHA	/release-go.yml: 69
	Unpinned Actions Full Length Commit SHA	/publish-wasm.yml: 86
	Unpinned Actions Full Length Commit SHA	/publish-java.yml: 98
	Unpinned Actions Full Length Commit SHA	/publish-ruby.yml: 92
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 337
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 60
	Unpinned Actions Full Length Commit SHA	/publish-php.yml: 89
	Unpinned Actions Full Length Commit SHA	/release-napi.yml: 44
	Unpinned Actions Full Length Commit SHA	/publish-java.yml: 82
	Unpinned Actions Full Length Commit SHA	/publish-php.yml: 176
	Unpinned Actions Full Length Commit SHA	/release-bws.yml: 43
	Unpinned Actions Full Length Commit SHA	/release-go.yml: 89
	Healthcheck Instruction Missing	/Dockerfile: 33
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 129
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 115
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 115
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 151
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 129
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/Secrets.cpp: 56
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 151
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 129
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/Secrets.cpp: 139
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 122
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 115
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 151
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 129
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/Secrets.cpp: 107
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 159
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 136
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 122
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 151
	Privacy_Violation	/languages/cpp/src/BitwardenClient.cpp: 129
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 172
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 162
	Unpinned Actions Full Length Commit SHA	/publish-ruby.yml: 92
	Unpinned Actions Full Length Commit SHA	/build-ruby.yml: 24
	Unpinned Actions Full Length Commit SHA	/release-cpp.yml: 65
	Unpinned Actions Full Length Commit SHA	/publish-php.yml: 89
	Unpinned Actions Full Length Commit SHA	/publish-python.yml: 107
	Unpinned Actions Full Length Commit SHA	/release-go.yml: 69
	Unpinned Actions Full Length Commit SHA	/release-wasm.yml: 42
	Unpinned Actions Full Length Commit SHA	/publish-dotnet.yml: 88
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 53
	Unpinned Actions Full Length Commit SHA	/release-dotnet.yml: 54
	Unpinned Actions Full Length Commit SHA	/release-bws.yml: 51
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 85
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 168
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 60
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 53
	Unpinned Actions Full Length Commit SHA	/release-cpp.yml: 59
	Unpinned Actions Full Length Commit SHA	/publish-php.yml: 176
	Unpinned Actions Full Length Commit SHA	/release-go.yml: 89
	Unpinned Actions Full Length Commit SHA	/publish-wasm.yml: 86
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 130
	Unpinned Actions Full Length Commit SHA	/publish-java.yml: 98
	Unpinned Actions Full Length Commit SHA	/release-bws.yml: 43
	Unpinned Actions Full Length Commit SHA	/publish-bws.yml: 92
	Unpinned Actions Full Length Commit SHA	/release-napi.yml: 44
	Unpinned Actions Full Length Commit SHA	/publish-java.yml: 82
	Unpinned Actions Full Length Commit SHA	/publish-napi.yml: 110
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 337
	Unpinned Actions Full Length Commit SHA	/release-ruby.yml: 51

codecov · 2024-10-21T16:40:39Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

.github/workflows/rust-test.yml

.github/workflows/version-bump.yml

dani-garcia

Just some missing names in the workflow, otherwise LGTM

.github/workflows/version-bump.yml

Hinton added 2 commits October 11, 2024 14:38

Remove secrets manager language bindings and clients

c75f247

Hinton changed the title ~~Remove secrets manager language bindings and clients~~ [PM-13376] Phase 2 - SDK split Oct 21, 2024

Hinton added 9 commits October 21, 2024 10:02

Remove bitwarden from build-rust-crates

b0b39a8

Change wasm test to use internal

402d19d

Check whole repo

655e6f2

Fix workflows

24aee10

Remove SM codeowners

2bbdfd3

Fix android

900f50b

Fix

cf9d7a2

I give up

3fefa19

Update gradle gh packages

9a0db4a

dani-garcia reviewed Oct 21, 2024

View reviewed changes

.github/workflows/rust-test.yml Outdated Show resolved Hide resolved

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved

Resolve review feedback

33cea35

Hinton requested a review from dani-garcia October 21, 2024 18:01

dani-garcia reviewed Oct 21, 2024

View reviewed changes

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved

Hinton added 2 commits October 21, 2024 11:09

Tweak

acf4638

2

988eed5

dani-garcia approved these changes Oct 21, 2024

View reviewed changes

Hinton merged commit 67ccb5a into main Oct 21, 2024
37 of 38 checks passed

Hinton deleted the repo-split-cleanup branch October 21, 2024 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-13376] Phase 2 - SDK split #2

[PM-13376] Phase 2 - SDK split #2

Hinton commented Oct 21, 2024

github-actions bot commented Oct 21, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024

dani-garcia left a comment

[PM-13376] Phase 2 - SDK split #2

[PM-13376] Phase 2 - SDK split #2

Conversation

Hinton commented Oct 21, 2024

🎟️ Tracking

📔 Objective

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions bot commented Oct 21, 2024 • edited Loading

New Issues

Fixed Issues

codecov bot commented Oct 21, 2024

Welcome to Codecov 🎉

dani-garcia left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2024 •

edited

Loading