Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14814] Add organization_use_totp to CipherListView #30

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 11, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14814

📔 Objective

Add organization_use_totp to CipherListView

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia November 11, 2024 16:47
@Hinton Hinton changed the title Add organization_use_totp to CipherListView [PM-14814] Add organization_use_totp to CipherListView Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.87%. Comparing base (a5f98db) to head (1cdfeba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   62.87%   62.87%           
=======================================
  Files         179      179           
  Lines       12696    12699    +3     
=======================================
+ Hits         7982     7985    +3     
  Misses       4714     4714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton enabled auto-merge (squash) November 11, 2024 16:59
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details51638ead-f58c-41d8-90bb-101d6fd833e5

No New Or Fixed Issues Found

@Hinton Hinton merged commit eee1b54 into main Nov 11, 2024
40 checks passed
@Hinton Hinton deleted the org-totp branch November 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants