-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15096] Add xchacha20-poly1305-blake3-ctx cipher #41
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 65.24% 65.68% +0.44%
==========================================
Files 181 182 +1
Lines 13821 13981 +160
==========================================
+ Hits 9018 9184 +166
+ Misses 4803 4797 -6 ☔ View full report in Codecov by Sentry. |
…twarden/sdk-internal into km/beeep/chacha20-poly1305-blake3-ctx
let mut buffer = Vec::from(plaintext_secret_data); | ||
let cipher = XChaCha20Poly1305::new(GenericArray::from_slice(key)); | ||
|
||
let poly1305_tag = cipher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want different errors here, or should all be the same? (in the latter case, it might need to be a new generic "symmetricdecryptionfailed"). In other contexts i might be concerned about the error being usable as an oracle (this is the case in some RSA implementations), but I do not think it is here.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15096
📔 Objective
Add a cryptofunction implementation for xchacha20-poly1305. Specifically, in order to prevent attacks making use of the lack of key-comitting, we implement ctx wrapping based on https://eprint.iacr.org/2022/1260.pdf using blake3, which creates a new mac that binds to all inputs (nonce, key, ad, ad tag), and by injectivity, also plaintext/ciphertext.
Note: There is no encstring implementation yet. The idea is for encstrings and for other protocols (IPC in rust?) to make use of this safe primitive.
Note: This is behind a compile-time feature flag for now.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes