Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xchacha20-poly1305-blake3-ctx cipher #41

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 1, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15096

📔 Objective

Add a cryptofunction implementation for xchacha20-poly1305. Specifically, in order to prevent attacks making use of the lack of key-comitting, we implement ctx wrapping based on https://eprint.iacr.org/2022/1260.pdf using blake3, which creates a new mac that binds to all inputs (nonce, key, ad, ad tag), and by injectivity, also plaintext/ciphertext.

Note: There is no encstring implementation yet. The idea is for encstrings and for other protocols (IPC in rust?) to make use of this safe primitive

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Logo
Checkmarx One – Scan Summary & Details2d474e51-9283-484c-8ebd-73d511852823

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (15f1d9c) to head (07524af).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-crypto/src/chacha20.rs 97.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   63.43%   63.69%   +0.25%     
==========================================
  Files         187      188       +1     
  Lines       12999    13116     +117     
==========================================
+ Hits         8246     8354     +108     
- Misses       4753     4762       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested a review from MGibson1 December 2, 2024 09:45
@quexten quexten changed the title Add chacha20-poly1305-blake3-ctx cipher Add xchacha20-poly1305-blake3-ctx cipher Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant