Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15096] Add xchacha20-poly1305-blake3-ctx cipher #41

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 1, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15096

📔 Objective

Add a cryptofunction implementation for xchacha20-poly1305. Specifically, in order to prevent attacks making use of the lack of key-comitting, we implement ctx wrapping based on https://eprint.iacr.org/2022/1260.pdf using blake3, which creates a new mac that binds to all inputs (nonce, key, ad, ad tag), and by injectivity, also plaintext/ciphertext.

Note: There is no encstring implementation yet. The idea is for encstrings and for other protocols (IPC in rust?) to make use of this safe primitive.

Note: This is behind a compile-time feature flag for now.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Logo
Checkmarx One – Scan Summary & Details941ab020-acbb-4fe2-b5a8-46a75fe81365

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (c9a0295) to head (0a77ae5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   65.24%   65.68%   +0.44%     
==========================================
  Files         181      182       +1     
  Lines       13821    13981     +160     
==========================================
+ Hits         9018     9184     +166     
+ Misses       4803     4797       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested a review from MGibson1 December 2, 2024 09:45
@quexten quexten changed the title Add chacha20-poly1305-blake3-ctx cipher Add xchacha20-poly1305-blake3-ctx cipher Dec 2, 2024
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
crates/bitwarden-crypto/src/chacha20.rs Fixed Show fixed Hide fixed
@quexten quexten changed the title Add xchacha20-poly1305-blake3-ctx cipher [PM-15096] Add xchacha20-poly1305-blake3-ctx cipher Dec 23, 2024
@quexten quexten marked this pull request as ready for review December 29, 2024 00:00
@quexten quexten marked this pull request as draft December 29, 2024 00:27
@quexten quexten marked this pull request as ready for review December 29, 2024 23:33
let mut buffer = Vec::from(plaintext_secret_data);
let cipher = XChaCha20Poly1305::new(GenericArray::from_slice(key));

let poly1305_tag = cipher
Copy link
Contributor Author

@quexten quexten Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want different errors here, or should all be the same? (in the latter case, it might need to be a new generic "symmetricdecryptionfailed"). In other contexts i might be concerned about the error being usable as an oracle (this is the case in some RSA implementations), but I do not think it is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant