Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: Update Rust crate rustls-platform-verifier to 0.4.0 #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2024

This PR contains the following updates:

Package Type Update Change
rustls-platform-verifier dependencies minor 0.3.4 -> 0.4.0

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@bitwarden-bot bitwarden-bot changed the title [deps]: Update Rust crate rustls-platform-verifier to 0.4.0 [PM-15726] [deps]: Update Rust crate rustls-platform-verifier to 0.4.0 Dec 9, 2024
@bitwarden-bot
Copy link

Internal tracking:

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (05c7966) to head (3dfdc86).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   63.85%   63.86%   +0.01%     
==========================================
  Files         186      186              
  Lines       12905    12892      -13     
==========================================
- Hits         8240     8233       -7     
+ Misses       4665     4659       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [PM-15726] [deps]: Update Rust crate rustls-platform-verifier to 0.4.0 [deps]: Update Rust crate rustls-platform-verifier to 0.4.0 Dec 9, 2024
@renovate renovate bot force-pushed the renovate/rustls-platform-verifier-0.x branch from 9e98694 to ec92c1e Compare December 9, 2024 13:39
@Hinton Hinton requested a review from dani-garcia December 9, 2024 15:14
Copy link
Contributor Author

renovate bot commented Dec 10, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb0ed5bce-91c1-4b9c-b1d6-8fa2d4764c98

No New Or Fixed Issues Found

@dani-garcia
Copy link
Member

dani-garcia commented Dec 10, 2024

@Hinton I've had to change the setup of rustls-platform-verifier slightly, as the old way is now deprecated. The new way requires us to explicitly use rustls, which means the previous test we had to do to ensure version compatibility is not needed anymore.

I've given this a quick test on Android and it seems to work still.

Tagging you for review as I had to make code changes.

@dani-garcia dani-garcia requested a review from Hinton December 10, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants