Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: Update Rust crate generic-array to v1 #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2024

This PR contains the following updates:

Package Type Update Change
generic-array dependencies major >=0.14.7, <1.0 -> >=0.14.7, <1.2

Release Notes

fizyk20/generic-array (generic-array)

v1.0.0

Changelog

Primary PR


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Dec 9, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bitwarden-crypto/Cargo.toml --package generic-array@0.14.7 --precise 1.1.1
    Updating crates.io index
error: failed to select a version for the requirement `generic-array = "^0.14.6"`
candidate versions found which didn't match: 1.1.1
location searched: crates.io index
required by package `elliptic-curve v0.13.8`
    ... which satisfies dependency `elliptic-curve = "^0.13.1"` (locked to 0.13.8) of package `p256 v0.13.2`
    ... which satisfies dependency `p256 = ">=0.13.2, <0.14"` (locked to 0.13.2) of package `bitwarden-fido v1.0.0 (/tmp/renovate/repos/github/bitwarden/sdk-internal/crates/bitwarden-fido)`
    ... which satisfies path dependency `bitwarden-fido` (locked to 1.0.0) of package `bitwarden-uniffi v0.1.0 (/tmp/renovate/repos/github/bitwarden/sdk-internal/crates/bitwarden-uniffi)`

@bitwarden-bot bitwarden-bot changed the title [deps]: Update Rust crate generic-array to v1 [PM-15734] [deps]: Update Rust crate generic-array to v1 Dec 9, 2024
@bitwarden-bot
Copy link

Internal tracking:

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.89%. Comparing base (ceba460) to head (a1c7863).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         186      186           
  Lines       12905    12905           
=======================================
  Hits         8246     8246           
  Misses       4659     4659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [PM-15734] [deps]: Update Rust crate generic-array to v1 [deps]: Update Rust crate generic-array to v1 Dec 9, 2024
@Hinton
Copy link
Member

Hinton commented Dec 9, 2024

@dani-garcia as far as I understand this should be safe to update? They don't explicitly mention any breaking changes.

@dani-garcia
Copy link
Member

I think all the rust-crypto crates are using generic-array 0.14, so if we update this, we're going to get two copies of the generic-array crate, and the older version might not have the zeroize flag enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants