Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete lockfile before running msrv check #70

Closed
wants to merge 1 commit into from
Closed

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 9, 2024

📔 Objective

We probably want to delete the lockfile before running msrv to ensure the appropriate dependencies are resolved. Since the lockfile generally contains newer versions.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia December 9, 2024 12:15
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Logo
Checkmarx One – Scan Summary & Details7d5babd4-1b72-4262-bf01-e385a791f27e

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.89%. Comparing base (4a15c6b) to head (f8f77ff).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         186      186           
  Lines       12905    12905           
=======================================
  Hits         8246     8246           
  Misses       4659     4659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton
Copy link
Member Author

Hinton commented Dec 9, 2024

Not doing this since cargo isn't MSRV aware. ....

@Hinton Hinton closed this Dec 9, 2024
@Hinton Hinton deleted the delete-lockfile branch December 9, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants