Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validator dependency to range #71

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Change validator dependency to range #71

merged 2 commits into from
Dec 9, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 9, 2024

📔 Objective

Supersedes #61. It's better to use a range than explicit dependency in case consumers already depend on a specific version.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia December 9, 2024 13:43
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Logo
Checkmarx One – Scan Summary & Detailsadaca8a2-4c3b-4146-bd27-9d0cc50101e9

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.87%. Comparing base (05c7966) to head (c922c29).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   63.85%   63.87%   +0.02%     
==========================================
  Files         186      186              
  Lines       12905    12905              
==========================================
+ Hits         8240     8243       +3     
+ Misses       4665     4662       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
@Hinton Hinton requested a review from dani-garcia December 9, 2024 14:57
@Hinton Hinton merged commit 5feb17e into main Dec 9, 2024
39 checks passed
@Hinton Hinton deleted the validator-range branch December 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants