Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WASM to use MVP for transpilation #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Dec 9, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Currently we're stuck on Rust 1.81 because 1.82 started enabling the reference-types feature by default, which breaks wasm2js. Ideally wasm2js would add support for it, but we don't know how long that is going to take.

To disable that feature, we need to use nightly or RUSTC_BOOTSTRAP to use the unstable build-std option. In this PR I'm building the WASM version normally first, and then with build-std for transpilation, though we could use build-std for both.

Local builds seem to work fine, but it'll need some more testing.

Note that webpack has support for reference-types in versions >=5.97.0, so we might want to make sure clients are updated first. Also the client support: https://caniuse.com/wasm-reference-types

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 1ea3c7df-e29a-4849-884d-4fb669e46f14

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build-wasm-internal.yml: 92 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build-wasm-internal.yml: 91

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 63.85%. Comparing base (05c7966) to head (32c62f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files         186      186           
  Lines       12905    12905           
=======================================
  Hits         8240     8240           
  Misses       4665     4665           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant