Update WASM to use MVP for transpilation #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐๏ธ Tracking
๐ Objective
Currently we're stuck on Rust 1.81 because 1.82 started enabling the
reference-types
feature by default, which breakswasm2js
. Ideallywasm2js
would add support for it, but we don't know how long that is going to take.To disable that feature, we need to use nightly or RUSTC_BOOTSTRAP to use the unstable
build-std
option. In this PR I'm building the WASM version normally first, and then withbuild-std
for transpilation, though we could usebuild-std
for both.Local builds seem to work fine, but it'll need some more testing.
Note that webpack has support for
reference-types
in versions>=5.97.0
, so we might want to make sure clients are updated first. Also the client support: https://caniuse.com/wasm-reference-typesโฐ Reminders before review
team
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes