Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI bindings #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Dec 13, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Using latest server main, at the moment a28e517eebe28da5f7d89183bbc8af3cc8e00428.

I've had to do some minor code updates, to add support for the FreeFamiliesSponsorshipPolicy policy and the SSH key type. I've also updated the openapi generator version, though the code generated is the same regardless of version.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f3cf0a2a-5c3f-4353-a2df-04aca3b6ee95

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (b7b8dec) to head (7a78902).

Files with missing lines Patch % Lines
crates/bitwarden-core/src/admin_console/policy.rs 0.00% 1 Missing โš ๏ธ
crates/bitwarden-vault/src/cipher/cipher.rs 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   64.43%   64.43%   -0.01%     
==========================================
  Files         188      188              
  Lines       13830    13832       +2     
==========================================
  Hits         8912     8912              
- Misses       4918     4920       +2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dani-garcia dani-garcia requested a review from Hinton December 13, 2024 12:50
@dani-garcia dani-garcia marked this pull request as ready for review December 13, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant