Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3431] Generate registration keys #198

Merged
merged 18 commits into from
Sep 5, 2023
Merged

[PM-3431] Generate registration keys #198

merged 18 commits into from
Sep 5, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Aug 28, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Implement key generations required for registration.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@bitwarden-bot
Copy link

bitwarden-bot commented Aug 28, 2023

Logo
Checkmarx One – Scan Summary & Details8c4e9317-79da-4e8c-b25d-709f5a4d45be

No New Or Fixed Issues Found

@Hinton Hinton marked this pull request as ready for review September 4, 2023 14:57
@Hinton Hinton changed the title WIP register support [PM-3431] Generate registration keys Sep 4, 2023
@Hinton Hinton requested a review from dani-garcia September 5, 2023 09:46
crates/bitwarden/src/client/encryption_settings.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/crypto/aes_ops.rs Show resolved Hide resolved
crates/bitwarden/src/crypto/rsa.rs Outdated Show resolved Hide resolved
crates/bitwarden/src/auth/register.rs Outdated Show resolved Hide resolved
@Hinton Hinton requested a review from dani-garcia September 5, 2023 12:34
dani-garcia
dani-garcia previously approved these changes Sep 5, 2023
@Hinton Hinton requested a review from dani-garcia September 5, 2023 14:40
@Hinton Hinton merged commit 766c85b into master Sep 5, 2023
39 checks passed
@Hinton Hinton deleted the ps/register branch September 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants