Add Sends API in bitwarden-uniffi #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Hinton
reviewed
Sep 4, 2023
|
Done, I also updated the prettierignore so that Not sure why but when I ran the doc generation the ExportFormat definition got deleted from the doc, so I restored it by hand. |
Hinton
reviewed
Sep 4, 2023
Comment on lines
+3
to
+4
| !/languages/kotlin | ||
| languages/kotlin/* |
There was a problem hiding this comment.
It's a bit awkward but that seems to be how the ignore file works yeah:
prettier/prettier#3328 (comment)
We could always remove it and add an extra step on the Readme to format the doc file after it's generated.
Hinton
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add missing Sends API to the bitwarden-uniffi crate.
Also fixed copy-pasted comment in the password history function